Handle blank reports

[Gwonwoo-Nam]

Summary

• ignore empty content when saving condition or improvement reports
• add regression tests for report services

Testing

• ./gradlew test --no-daemon (fails: Unable to tunnel through proxy)

---

https://chatgpt.com/codex/tasks/task_e_6841c029874c832d9ea00cf97db9280d

Summary by CodeRabbit

• Bug Fixes

  • Prevented saving of condition and improvement reports when the content is blank or missing.

• Tests

  • Added tests to verify that reports with blank content are not saved.

[coderabbitai]

Walkthrough

The changes update the logic in both ConditionReportService and ImprovementReportService to prevent saving reports with null or blank content. Corresponding unit tests are added or updated to verify that reports with blank content are not persisted by the repository.

Changes

File(s)	Change Summary
src/main/kotlin/upbrella/be/rent/service/ConditionReportService.kt ...ImprovementReportService.kt	Modified service methods to only save reports if content is non-null and not blank.
src/test/kotlin/upbrella/be/rent/service/ConditionReportServiceTest.kt	Added nested test class and method to verify blank content is not saved for condition reports.
src/test/kotlin/upbrella/be/rent/service/ImprovementReportServiceTest.kt	Added new test class and method to verify blank content is not saved for improvement reports.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Service
    participant Repository

    Client->>Service: save(report)
    alt report.content is non-null and not blank
        Service->>Repository: save(report)
    else report.content is null or blank
        Service-->>Client: Do not save, exit
    end

Loading

Suggested reviewers

• birdieHyun

Poem

In the warren where reports are made,
Only those with words will not fade.
Blank and empty, they hop away,
Saved are those with something to say.
Tests now guard this clever gate—
Only true content meets its fate!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 231f159 and dc2be15.

📒 Files selected for processing (4)

• src/main/kotlin/upbrella/be/rent/service/ConditionReportService.kt (1 hunks)
• src/main/kotlin/upbrella/be/rent/service/ImprovementReportService.kt (1 hunks)
• src/test/kotlin/upbrella/be/rent/service/ConditionReportServiceTest.kt (2 hunks)
• src/test/kotlin/upbrella/be/rent/service/ImprovementReportServiceTest.kt (1 hunks)

🔇 Additional comments (7)

src/main/kotlin/upbrella/be/rent/service/ImprovementReportService.kt (1)

17-21: LGTM! Excellent use of Kotlin idioms for conditional saving.

The implementation correctly prevents saving reports with null or blank content using safe call operators and scope functions. The use of isNotBlank() properly handles null, empty, and whitespace-only content.

src/main/kotlin/upbrella/be/rent/service/ConditionReportService.kt (1)

17-21: LGTM! Consistent implementation across services.

The implementation matches the pattern used in ImprovementReportService, ensuring consistent behavior for handling blank reports across the codebase. The logic correctly prevents saving when content is null or blank.

src/test/kotlin/upbrella/be/rent/service/ImprovementReportServiceTest.kt (3)

21-28: LGTM! Proper test setup with Mockito.

The test class is well-structured with appropriate mocking setup using MockitoExtension and proper injection of dependencies.

---

32-54: LGTM! Comprehensive test data setup.

The setUp method creates all necessary entity relationships (StoreMeta, Umbrella, User, History) required for testing, ensuring the test has proper context.

---

56-67: LGTM! Effective test for blank content handling.

The test correctly verifies that when content contains only whitespace (" "), the repository save method is never called. The use of times(0) with Mockito verification is the appropriate way to assert no interaction occurred.

src/test/kotlin/upbrella/be/rent/service/ConditionReportServiceTest.kt (2)

15-15: LGTM! Required import for test verification.

The addition of ArgumentMatchers.any import supports the new test method's verification logic.

---

127-143: LGTM! Well-organized nested test class with consistent verification.

The nested test class appropriately groups the blank content handling tests. The test logic mirrors the ImprovementReportServiceTest implementation, ensuring consistent behavior verification across both services. The reuse of existing test fixtures is efficient and maintains good test organization.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.