Skip to content

PR for 5.3.0 release#179

Draft
cbuahin wants to merge 79 commits intodevelopfrom
bug_fixes
Draft

PR for 5.3.0 release#179
cbuahin wants to merge 79 commits intodevelopfrom
bug_fixes

Conversation

@cbuahin
Copy link
Contributor

@cbuahin cbuahin commented Jun 3, 2024

No description provided.

cbuahin added 28 commits November 1, 2023 10:56
@cbuahin
Work in progress addressing #149
6bcd52c
@cbuahin
Addressing bug for mod. horton #59
81095bc
@cbuahin
Addressing bug for mod. horton #59
353f8fe
@cbuahin
Enabling draining in isolated and surcharged storages #149
ee1b5ef
@cbuahin
Restore openmp for node updating
f9fa0ed
@cbuahin
Valid double comparison since sumdqdh is initialized to zero for dang…
059d342 
…ling node #149
@cbuahin
Make sure ellipse ratio is 1.56 to be consistent with GUI #144
d93cb32
@cbuahin
Leave users to prescribe rise and span #144
a621234
@cbuahin
Address zero depth outfall bug #154
4606020
@cbuahin
Bumping minor version number up
a6fa0d5
@cbuahin
Addressing TotalDuration precision bug #152
57cf5fa
@cbuahin
Limiting cummulative infiltration to max #158
d67a757
@cbuahin
Added support for saving multiple hotstart files at specified times #150
a409713
@cbuahin
Modified code to use global consts instead of locally defined values #70
e3309b6
@cbuahin
WIP addressing #162, #150
9cad38b
@cbuahin
WIP addressing #162, #150
91de2fd
@cbuahin
WIP addressing #162, #150
cd5120d
@cbuahin
WIP addressing #162, #150
5d933ae
@cbuahin
WIP addressing #162, #150; Remove actions for bug_fixes branch
ea5e68a
@cbuahin
WIP addressing #162, #150
e1f906e
@cbuahin
Expand API to return error code and support unit testing #162
58e330b
@cbuahin
WIP on expanding unit tests #162, #150; other minor refactoring
66e9f61
@cbuahin
WIP on expanding unit tests #162, #150; other minor refactoring
1b4559e
@cbuahin
WIP on expanding unit tests #162, #150; other minor refactoring
71c79e3
@cbuahin
Work in progress #162, #163
89fd7dd
@cbuahin
Addressing crashing for long comments in timeseries #165
bbaf4fe
@cbuahin
Add runoff from closed rain barrel to return flow #166
9d3bb8d
@cbuahin
Add runoff from closed rain barrel to return flow #166
25dd291
@LRossman
Copy link
Collaborator

LRossman commented Jun 3, 2024

@cbuahin I'm happy to see you are making progress on pushing out a version 5.3. I was hoping it would include the improvements to how submerged inlets are handled as described in issue #139 and implemented in the the inlet_improvement branch. As I didn't see it included on this set of commits I'm hoping you will eventually add it to the v5.3 pipeline since it provides a more physically realistic way of modeling sewer overflow onto the street than does the current method used in v5.2.4.

cbuahin and others added 22 commits March 3, 2025 04:51
@cbuahin
Unit testing workflow #204, #162, #163, #184, #180, #165, #31
50ee476 
Signed-off-by: Caleb <calebgh@gmail.com>
@cbuahin
Nuget workflow is allowed now
1fbde01 
Signed-off-by: Caleb <calebgh@gmail.com>
@cbuahin
Nuget workflow is allowed now
79d5f06 
Signed-off-by: Caleb <calebgh@gmail.com>
@cbuahin
Qualify package name with os and vcpkg triplet
abab08d 
Signed-off-by: Caleb <calebgh@gmail.com>
@cbuahin
Qualify oss with if clauses
3289bcb 
Signed-off-by: Caleb <calebgh@gmail.com>
@cbuahin
Configure workspace for build correctly
43c18e1 
Signed-off-by: Caleb <calebgh@gmail.com>
@cbuahin
Configure workspace for build correctly
9ba76ef 
Signed-off-by: Caleb <calebgh@gmail.com>
@cbuahin
Configure workspace for build correctly; test windows only
dc19c44 
Signed-off-by: Caleb <calebgh@gmail.com>
@cbuahin
Configure workspace for build correctly; test windows only
c917b98 
Signed-off-by: Caleb <calebgh@gmail.com>
@cbuahin
Configure workspace for build correctly; test windows only
bc1ccea 
Signed-off-by: Caleb <calebgh@gmail.com>
Configuring vcpkg on windows
0074dee 
Signed-off-by: cbuahin <caleb.buahin@gmail.com>
Configuring vcpkg
8577239 
Signed-off-by: cbuahin <caleb.buahin@gmail.com>
Checking if vcpkg install locally is working
e99c37c 
Signed-off-by: cbuahin <caleb.buahin@gmail.com>
Fixing checkout path
7fdd0fd 
Signed-off-by: cbuahin <caleb.buahin@gmail.com>
Use github actions cache instead of nuget to simplify
25db75c
Use CC0-1.0 instead of Public domain as vcpkg does not recognize
fc05ffb 
Signed-off-by: cbuahin <caleb.buahin@gmail.com>
Bump vcpkg baseline
87662f7 
Signed-off-by: cbuahin <caleb.buahin@gmail.com>
Fix build directory
3e278f2 
Signed-off-by: cbuahin <caleb.buahin@gmail.com>
Reconfiguring boost
4bf8951 
Signed-off-by: cbuahin <caleb.buahin@gmail.com>
Configuring cibuildwheel for portability
5966f12 
Signed-off-by: cbuahin <caleb.buahin@gmail.com>
Sorting on GitHub actions for unit testing and building python wheels
506fb7a
Sorting on GitHub actions for unit testing and building python wheels
44ee734 
Signed-off-by: cbuahin <caleb.buahin@gmail.com>
cbuahin and others added 3 commits April 8, 2025 11:48
@cbuahin
Configuring unit testing and building for deployment
4e4c78a 
Signed-off-by: Caleb <calebgh@gmail.com>
@cbuahin
Update README.md
2763347
@cbuahin
Cleaning up build and fixing install on windows
ebc35ad 
Signed-off-by: Caleb <calebgh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 2 approving reviews are required to merge this pull request.

Assignees

@cbuahin cbuahin

Labels

None yet

Projects

None yet

Milestone

v5.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@cbuahin @LRossman @michaeltryby @jubilee2 @MdoubleDash