Addresses Issue #139 -- Code for inlets does not account for submergence#195
Open
michaeltryby wants to merge 1 commit intodevelopfrom
Open
Addresses Issue #139 -- Code for inlets does not account for submergence#195michaeltryby wants to merge 1 commit intodevelopfrom
michaeltryby wants to merge 1 commit intodevelopfrom
Conversation
These code changes provide a more rigorous way of modeling two way flow between sewer and street nodes when the HGL of a sewer node reaches street elevation.
agugelp-source
approved these changes
Aug 23, 2025
agugelp-source
left a comment
agugelp-source
left a comment
There was a problem hiding this comment.
Thank you. I had a problem where a conduit node had a very low ground level. The street node was linked by inlets to the conduit node. When the conduit overflowed it had an HGL in the conduit node more than two meters higher than the HGL of the street node. This was because the sink was not modeling the reverse flow. Using the code worked perfectly and the HGL results were very similar on both nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These code changes provide a more rigorous way of modeling two way flow between sewer and street nodes when the HGL of a sewer node reaches street elevation.
closes #139