Expanded the number of characters in the part of the vic2netcdf.py#17
Open
orianac wants to merge 1 commit intoUW-Hydro:developfrom
Open
Expanded the number of characters in the part of the vic2netcdf.py#17orianac wants to merge 1 commit intoUW-Hydro:developfrom
orianac wants to merge 1 commit intoUW-Hydro:developfrom
Conversation
code that reads filenames to find the coordinates. Before, the code would break if the output files were at 1/16th degree resolution because the number of characters of a XX.XXXXX_-XXX.XXXXX would exceed the counted characters and the coordinate mapping would fail.
Member
|
Thanks but I think the better way to approach this is to make this a option in the config file. I'll leave this open but I think it will require a bit more work. |
Member
|
@orianac - This should push you in the right direction: tuple(map(float, os.path.splitext(os.path.basename(filename))[0].split('_')[-2:]))We want to test this though so if you could add a few short tests to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code that reads filenames to find the coordinates. Before, the
code would break if the output files were at 1/16th degree resolution
because the number of characters of a XX.XXXXX_-XXX.XXXXX would
exceed the counted characters and the coordinate mapping would
fail.