Created linking from hours to coords and modified the coords layout #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oz's name for hyperlinks andrew and maya still need to add their bios to _data/coords.yaml
LOZORD
approved these changes
Sep 10, 2018
coords.html
Outdated
| @@ -10,30 +10,35 @@ <h2>Coordinators</h2> | |||
|
|
|||
| <p>These are the people responsible for the daily operation and maintenance of the UPL. If you have any questions email us at: <a href="http://www.google.com/recaptcha/mailhide/d?k=01enlvO279JKQY5RDqwSAZng==&c=27tAYEUKmtum-50yZuZ4fT4un5toOiloDmEWiGfH0go=" onclick="window.open('http://www.google.com/recaptcha/mailhide/d?k\07501enlvO279JKQY5RDqwSAZng\75\75\46c\07527tAYEUKmtum-50yZuZ4fT4un5toOiloDmEWiGfH0go\075', '', 'toolbar=0,scrollbars=0,location=0,statusbar=0,menubar=0,resizable=0,width=500,height=300'); return false;" title="Reveal this e-mail address">u...</a>@cs.wisc.edu.</p> | |||
|
|
|||
| <ul class="coords-list"> | |||
| <!-- <ul class="coords-list"> --> | |||
| <li> | ||
| {% assign photo = coord.photo || 'default.png' %} | ||
| <div><a href="#{{ coord.name }}"></a></div> | ||
| <div class="coord-mug"><img title="{{coord.name}}" src="{{'images/coords/' | append: photo | prepend: site.baseurl }}" /></div> |
There was a problem hiding this comment.
Put a line break in here somewhere.
| <br /> | ||
| {% if coord.emoji %} | ||
| <p>Favorite emoji: | ||
| <img class="emoji" title=":{{ coord.emoji }}:" alt=":{{ coord.emoji }}:" src="https://assets-cdn.github.com/images/icons/emoji/{{coord.emoji}}.png" height="20" width="20" align="absmiddle" /> |
There was a problem hiding this comment.
Here too. Attributes should be able to be across multiple lines.
There was a problem hiding this comment.
Basically, 80 character limit please 😸
Nicell
force-pushed
the
master
branch
2 times, most recently
from
9ac0be8 to
298b057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #17