Add CameraManager 1 and 2 implementations#8
Open
KR-1234 wants to merge 2 commits into
Open
Conversation
…logy - Add Camera1Manager.md and Camera2Manager.md: Layer 2 Active hardware manager SDDs following the flat SM pattern (OFF → RESET → WAIT_RESET → ENABLE → CONFIGURE → RUN). Cameras are command-driven (POWER_ON, POWER_OFF, CONFIGURE, CAPTURE via Fw.Cmd cmdIn) and push frames to DataCollectionApplication via Cam.ImagePort. - Update DataCollectionApplication.md: add missing imageIn[2]: Cam.ImagePort input port to receive frames from both camera managers. - Update sdd.md: correct camera manager SM descriptions to include OFF state, add Camera1Manager and Camera2Manager to RateGroup2 schedule, define Cam.ImagePort in synchronized capture section. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
The overall architecture of Camera1 looks very reasonable to me. However, if it is truly the case that Camera1 and Camera2 are identical as you suggest in your Camera2 document, then they should be one F Prime component with two instances in the topology. That said, please check the datasheets for both cameras to verify that they have the same hardware interfaces (I would be a bit surprised if they are different models and have the same hardware interfaces). @j4lando do you have any input re: the Camera design or data collection topology? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Camera1Manager.md and Camera2Manager.md as Layer 2 hardware manager SDDs.