Skip to content

Rewrite of ChangeAtZ #20512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rewrite of ChangeAtZ #20512

wants to merge 2 commits into from

Conversation

GregValiant
Copy link
Collaborator

@GregValiant GregValiant commented Apr 15, 2025 •
edited
Loading

A lot of changes to bring it up to 5.x settings. Fixed "by Height" to work with Z-hops and Adaptive Layers. Split the speed changes into Print, Print+Travel, and Retraction so they don't all react to a speed change (no more M220).

I'll leave this as a draft until reviewers can get around to it.

Description

image

This fixes... OR This improves... -->

  • [ X] Update to an old favorite (non-breaking change which adds functionality.
  • [ X] Bug fix to allow it to work with Z-hops and adaptive layers.

Test Configuration:

  • Operating System:
  • Windows 10 Pro, Intel laptop
  • Cura 5.7 and up

Checklist:

  • [ X] My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
  • [ X] I have read the Contribution guide
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [ X] I have uploaded any files required to test this change

@GregValiant
Rewrite of ChangeAtZ
b1968be 
A lot of changes to bring it up to 5.x settings.  Fixed "by Height" to work with Z-hops and Adaptive Layers.  Split the speed changes into Print, Travel, Retraction.
@GregValiant GregValiant marked this pull request as draft April 15, 2025 22:01
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Apr 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025 •
edited
Loading

Test Results

23 783 tests  ±0   23 781 ✅ ±0   45s ⏱️ -2s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 62b2f71. ± Comparison against base commit 43a055c.

♻️ This comment has been updated with latest results.

@GregValiant GregValiant added the PR: Post Processing ➕ Like adding beeps, more tunability or different Gcode pause at heights label Apr 15, 2025
@jellespijker jellespijker requested a review from Copilot April 24, 2025 21:45
Copilot
Copilot AI reviewed Apr 24, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@GregValiant GregValiant marked this pull request as ready for review May 22, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@HellAholic HellAholic Awaiting requested review from HellAholic

@wawanbreton wawanbreton Awaiting requested review from wawanbreton

Assignees
No one assigned
Labels
PR: Community Contribution 👑 Community Contribution PR's PR: Post Processing ➕ Like adding beeps, more tunability or different Gcode pause at heights
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GregValiant