Skip to content

Conversation

@GregValiant
Copy link
Collaborator

@GregValiant GregValiant commented Sep 6, 2025

Update to account for the new "machine_time_estimation_factor" in Cura PR #20928 . The only real problem was a double application of the percentage in the Message dialog. The gcode itself was not affected.

Since machine_time_estimation_factor does not affect the "TIME" or "TIME_ELAPSED" lines in the gcode it is still useful in the script.

Description

Adding the script to a project will grab the "machine_time_estimation_factor" from Cura and use it as the default in the script.

This fixes... OR This improves... -->

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration: Win 5.11.alpha

  • Operating System: Win10 Pro

Checklist:

  • [ X] My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
  • [ X] I have read the Contribution guide
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [ X] I have uploaded any files required to test this change

Update to account for the new Time Estimate Factor in Cura.
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Sep 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2025

Test Results

0 tests   - 23 981   0 ✅  - 23 979   0s ⏱️ -47s
0 suites  -      1   0 💤  -      2 
0 files    -      1   0 ❌ ±     0 

Results for commit f1637c6. ± Comparison against base commit ede8b7e.

♻️ This comment has been updated with latest results.

Fixed the code from an older version.
@GregValiant GregValiant marked this pull request as draft September 7, 2025 23:34
@HellAholic HellAholic marked this pull request as ready for review September 8, 2025 06:44
Changed "global_stack" to "self.global_stack" to fix a bug.
Update to the anticipated addition of the "machine_time_estimation_factor".
The plan is for this to be backward compatible.
@GregValiant
Copy link
Collaborator Author

@HellAholic,
My 5.11 beta version does not have the "Time Adjustment" in the Machine Settings. Is there a plan to include it?

I ask because this PR is to accommodate it in DisplayInfoOnLCD. My problem is that I've found another minor bug in the script and it needs a PR to fix it. I don't know whether to pile it onto this one, or scrap this one and just put a new one in for the bug fix.

@HellAholic HellAholic changed the base branch from main to CURA-12701_user_estimation_factor October 5, 2025 06:15
@HellAholic
Copy link
Contributor

The time adjustment PR is created by me so I cannot review it and the devs were busy with the paint feature for the 5.11 beta.
I don't think it will be in 5.11;
I would keep the PRs separate for this one and the bug, I updated this PR to be merged into the time adjustment PR, so it will have the same fate as that PR when it's merged or not (easier to keep track of things).

@GregValiant
Copy link
Collaborator Author

I'm going to close this as the adjustments to account for "Time Adjustment" appear to be premature.

@GregValiant GregValiant closed this Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Community Contribution 👑 Community Contribution PR's

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants