Skip to content

Z seam middle option #20935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Z seam middle option #20935

wants to merge 4 commits into from

Conversation

@HellAholic
Copy link
Contributor

@HellAholic HellAholic commented Sep 8, 2025 •
edited
Loading

Description

  • Adds an option for Z Seam at middle
  • Adds an option to set the layer start X and Y to the z seam position (only available on user defined z seam position)
  • I blame Greg

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Slice and preview on machine with origin at center with different options
  • Slice and preview on machine with origin at front-left with different options
    Machine center is zero (origin at center)
    A) Z seam relative
    B) Z seam absolute
    Machine center is not zero (origin at front left)
    A) Z seam relative
    B) Z seam absolute

Test Configuration:

  • Operating System: Windows 11

Checklist:

@HellAholic
Add z seam middle option
58f9c51
@HellAholic
add layer start at z seam option
e18767e
@HellAholic
add formula to set the layer_start_x and layer_start_y to the z seam …
d735109 
…x and z seam y

Also considering that the z seam might be relative on a printer on which the origin is not at center.
@HellAholic
cover the edge case for machine center and z seam relative
9c02848 
Machine center is zero
A) Z seam relative -> no change needed to the values, z_seam_x and z_seam_y are correct values
B) Z seam absolute -> no change needed to the values, z_seam_x and z_seam_y are correct values
Machine center is not zero
A) Z seam relative -> should add half the machine_width to x, and should add half machine_height to y
B) Z seam absolute -> no change needed to the values, z_seam_x and z_seam_y are correct values
@HellAholic HellAholic added Type: Improvement Improvement to existing functionality. PR: Community Contribution 👑 Community Contribution PR's labels Sep 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

Test Results

23 981 tests  ±0   23 979 ✅ ±0   47s ⏱️ ±0s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 9c02848. ± Comparison against base commit ede8b7e.

@GregValiant
Copy link
Collaborator

GregValiant commented Sep 8, 2025

"I blame Greg"
I have large shoulders that can carry the weight.
I have bad knees that cannot.

Now horseshoe shapes can come out with the Z-seam on the inside.
image
(They always could if the user knew to change the numbers.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Community Contribution 👑 Community Contribution PR's Type: Improvement Improvement to existing functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HellAholic @GregValiant