Skip to content

CURA-12446 top bottom wall count v3 #21634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Erwan MATHIEU (wawanbreton) wants to merge 7 commits into
base: main
Choose a base branch
from
+208 −145
Open

CURA-12446 top bottom wall count v3 #21634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1f0b6a1
Add settings for flooring/roofing/initial wall count
wawanbreton May 28, 2026
95e3220
Merge remote-tracking branch 'origin/main' into CURA-12446_top_bottom…
wawanbreton May 28, 2026
00e0aad
Replace extra skin wall by detailed wall counts
wawanbreton May 29, 2026
4ea699b
Replace extra infill skin wall by wall counts
wawanbreton May 29, 2026
7a67728
Merge remote-tracking branch 'origin/main' into CURA-12446_top_bottom…
wawanbreton Jun 1, 2026
4c0d1e1
Upgrade definitions and profiles
wawanbreton Jun 1, 2026
2727932
Apply printer-linter format
wawanbreton Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 92 additions & 29 deletions resources/definitions/fdmprinter.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,96 @@
"type": "int",
"value": "1 if magic_spiralize else max(1, round((wall_thickness - wall_line_width_0) / wall_line_width_x) + 1) if wall_thickness != 0 else 0",
"limit_to_extruder": "wall_x_extruder_nr",
"settable_per_mesh": true
"settable_per_mesh": true,
"children":
{
"wall_line_count_skin":
{
"label": "Wall Line Count Skin",
"description": "The number of walls in the skin parts. This allows for setting less (or more) walls to parts of the model 'exposed to air'.",
"default_value": 3,
"value": "wall_line_count + (0 if top_bottom_pattern == 'concentric' and top_bottom_pattern_0 == 'concentric' and roofing_layer_count <= 0 else 1)",
"minimum_value": "0",
"maximum_value_warning": "10",
"maximum_value": "999999",
"type": "int",
"enabled": "((top_layers > 0 and roofing_layer_count > 0) or (bottom_layers > 0 and flooring_layer_count > 0))",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true,
"children":
{
"wall_line_count_inside_skin":
{
"label": "Wall Line Count Inside Skin",
"description": "The number of walls in the inside skin parts, not 'exposed to air'.",
"default_value": 3,
"value": "wall_line_count_skin",
"minimum_value": "0",
"maximum_value_warning": "10",
"maximum_value": "999999",
"type": "int",
"enabled": "bottom_layers > 0",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true
},
"wall_line_count_layer_0":
{
"label": "Wall Line Count Initial Layer",
"description": "The number of walls in the initial layer.",
"default_value": 3,
"value": "wall_line_count_skin",
"minimum_value": "0",
"maximum_value_warning": "10",
"maximum_value": "999999",
"type": "int",
"enabled": "bottom_layers > 0",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true
},
"wall_line_count_roofing":
{
"label": "Wall Line Count Top",
"description": "The number of walls in the top-most skin parts, 'exposed to air'.",
"default_value": 3,
"value": "wall_line_count_skin",
"minimum_value": "0",
"maximum_value_warning": "10",
"maximum_value": "999999",
"type": "int",
"enabled": "top_layers > 0 and roofing_layer_count > 0",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true
},
"wall_line_count_flooring":
{
"label": "Wall Line Count Bottom",
"description": "The number of walls in the bottom-most skin parts, 'exposed to air'.",
"default_value": 3,
"value": "wall_line_count_skin",
"minimum_value": "0",
"maximum_value_warning": "10",
"maximum_value": "999999",
"type": "int",
"enabled": "bottom_layers > 0 and flooring_layer_count > 0",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true
}
}
},
"infill_wall_line_count":
{
"label": "Wall Line Count Infill",
"description": "The number of walls around the infill area. Such walls can make top/bottom skin lines sag down less which means you need less top/bottom skin layers for the same quality at the cost of some extra material.\nThis feature can combine with the Connect Infill Polygons to connect all the infill into a single extrusion path without the need for travels or retractions if configured right.",
"default_value": 2,
"value": "wall_line_count",
"type": "int",
"minimum_value": "0",
"maximum_value": "999999",
"enabled": "infill_sparse_density > 0",
"limit_to_extruder": "infill_extruder_nr",
"settable_per_mesh": true
}
}
}
}
},
Expand Down Expand Up @@ -1883,20 +1972,6 @@
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true
},
"skin_outline_count":
{
"label": "Extra Skin Wall Count",
"description": "Replaces the outermost part of the top/bottom pattern with a number of concentric lines. Using one or two lines improves roofs that start on infill material.",
"value": "0 if top_bottom_pattern == 'concentric' and top_bottom_pattern_0 == 'concentric' and roofing_layer_count <= 0 else 1",
"default_value": 1,
"minimum_value": "0",
"maximum_value_warning": "10",
"maximum_value": "999999",
"type": "int",
"enabled": "(top_layers > 0 or bottom_layers > 0) and (top_bottom_pattern != 'concentric' or top_bottom_pattern_0 != 'concentric' or (roofing_layer_count > 0 and roofing_pattern != 'concentric'))",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true
},
"ironing_enabled":
{
"label": "Enable Ironing",
Expand Down Expand Up @@ -2269,8 +2344,8 @@
"description": "Connect infill paths where they run next to each other. For infill patterns which consist of several closed polygons, enabling this setting greatly reduces the travel time.",
"type": "bool",
"default_value": true,
"value": "(infill_pattern == 'cross' or infill_pattern == 'cross_3d' or infill_multiplier % 2 == 0) and infill_wall_line_count > 0",
"enabled": "infill_pattern != 'lightning' and (infill_pattern == 'cross' or infill_pattern == 'cross_3d' or infill_pattern == 'concentric' or infill_multiplier % 2 == 0 or infill_wall_line_count > 1)",
"value": "(infill_pattern == 'cross' or infill_pattern == 'cross_3d' or infill_multiplier % 2 == 0) and infill_wall_line_count > wall_line_count",
"enabled": "infill_pattern != 'lightning' and (infill_pattern == 'cross' or infill_pattern == 'cross_3d' or infill_pattern == 'concentric' or infill_multiplier % 2 == 0 or infill_wall_line_count > (wall_line_count + 1))",
"limit_to_extruder": "infill_extruder_nr",
"settable_per_mesh": true
},
Expand Down Expand Up @@ -2320,18 +2395,6 @@
"limit_to_extruder": "infill_extruder_nr",
"settable_per_mesh": true
},
"infill_wall_line_count":
{
"label": "Extra Infill Wall Count",
"description": "Add extra walls around the infill area. Such walls can make top/bottom skin lines sag down less which means you need less top/bottom skin layers for the same quality at the cost of some extra material.\nThis feature can combine with the Connect Infill Polygons to connect all the infill into a single extrusion path without the need for travels or retractions if configured right.",
"default_value": 0,
"type": "int",
"minimum_value": "0",
"maximum_value": "999999",
"enabled": "infill_sparse_density > 0",
"limit_to_extruder": "infill_extruder_nr",
"settable_per_mesh": true
},
"sub_div_rad_add":
{
"label": "Cubic Subdivision Shell",
Expand Down
2 changes: 1 addition & 1 deletion resources/definitions/hms434.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@
"retraction_hop_enabled": { "value": false },
"retraction_min_travel": { "value": "(round(line_width * 10))" },
Comment thread
wawanbreton marked this conversation as resolved.
"roofing_layer_count": { "value": "0" },
"skin_outline_count": { "value": "0" },
"skirt_brim_minimal_length": { "value": 50 },
Comment thread
wawanbreton marked this conversation as resolved.
"skirt_gap": { "value": 1 },
"speed_ironing": { "value": "150" },
Expand Down Expand Up @@ -175,6 +174,7 @@
"top_bottom_thickness": { "value": "(layer_height_0 + (layer_height * (top_layers - 1)))" },
"top_layers": { "value": "4 if infill_sparse_density < 95 else 1" },
"wall_0_inset": { "value": "0" },
"wall_line_count_skin": { "value": "wall_line_count" },
"wall_overhang_angle": { "value": 60 },
Comment thread
wawanbreton marked this conversation as resolved.
Comment thread
wawanbreton marked this conversation as resolved.
"wall_thickness": { "value": "(line_width * 3) if infill_sparse_density < 95 else line_width" },
"z_seam_corner": { "value": "'z_seam_corner_inner'" },
Expand Down
2 changes: 1 addition & 1 deletion resources/definitions/inat_base.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
"retraction_hop_enabled": { "value": true },
"retraction_speed": { "value": 45 },
"roofing_layer_count": { "value": 2 },
"skin_outline_count": { "value": 2 },
"skirt_brim_minimal_length": { "value": 500 },
"skirt_gap": { "value": 10 },
"skirt_line_count": { "value": 5 },
Expand Down Expand Up @@ -321,6 +320,7 @@
"support_z_distance": { "value": "layer_height if (2*layer_height > 0.8*machine_nozzle_size) else (2*layer_height)" },
"top_bottom_pattern": { "value": "'zigzag'" },
"top_bottom_thickness": { "value": 1.0 },
"wall_line_count_skin": { "value": "wall_line_count + 2" },
"wall_thickness": { "value": "max(3*wall_line_width, 1)" },
"xy_offset_layer_0": { "value": "-0.5*line_width" }
}
Expand Down
4 changes: 2 additions & 2 deletions resources/definitions/maker_made_300x.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"infill_overlap": { "value": 10 },
"infill_sparse_density": { "value": 20 },
Comment thread
wawanbreton marked this conversation as resolved.
"infill_support_enabled": { "value": false },
Comment thread
wawanbreton marked this conversation as resolved.
"infill_wall_line_count": { "value": 0 },
"infill_wall_line_count": { "value": "wall_line_count" },
Comment thread
wawanbreton marked this conversation as resolved.
"infill_wipe_dist": { "value": 0.1 },
Comment thread
wawanbreton marked this conversation as resolved.
"initial_layer_line_width_factor": { "value": 100 },
"inset_direction": { "value": "'inside_out'" },
Comment thread
wawanbreton marked this conversation as resolved.
Expand Down Expand Up @@ -96,7 +96,6 @@
"retraction_speed": { "value": 45 },
"roofing_layer_count": { "value": 1 },
"skin_no_small_gaps_heuristic": { "value": true },
"skin_outline_count": { "value": 1 },
"skin_overlap": { "value": 5 },
"skirt_gap": { "value": 3 },
"skirt_line_count": { "value": 2 },
Comment thread
wawanbreton marked this conversation as resolved.
Expand Down Expand Up @@ -139,6 +138,7 @@
"travel_retract_before_outer_wall": { "value": false },
"wall_0_inset": { "value": 0 },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_0_wipe_dist": { "value": 0.2 },
"wall_line_count_skin": { "value": "wall_line_count + 1" },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_line_width_0": { "value": 0.4 },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_thickness": { "value": 0.8 },
Comment thread
wawanbreton marked this conversation as resolved.
"xy_offset": { "value": 0 },
Comment thread
wawanbreton marked this conversation as resolved.
Expand Down
2 changes: 1 addition & 1 deletion resources/definitions/peopoly_moai.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@
},
"skin_line_width": { "minimum_value_warning": "machine_nozzle_size" },
"skin_no_small_gaps_heuristic": { "value": "False" },
"skin_outline_count": { "value": 0 },
"skin_overlap": { "value": 5 },
"skirt_brim_line_width": { "minimum_value_warning": "machine_nozzle_size" },
"speed_infill": { "maximum_value_warning": "300" },
Comment thread
wawanbreton marked this conversation as resolved.
Expand Down Expand Up @@ -177,6 +176,7 @@
},
"top_thickness": { "minimum_value_warning": "resolveOrValue('layer_height')" },
"wall_0_wipe_dist": { "value": "machine_nozzle_size / 3" },
"wall_line_count_skin": { "value": "wall_line_count" },
"wall_line_width": { "minimum_value_warning": "machine_nozzle_size" },
"wall_line_width_x": { "minimum_value_warning": "machine_nozzle_size" },
"wall_thickness": { "value": "0.5" },
Expand Down
2 changes: 1 addition & 1 deletion resources/definitions/skriware_2.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@
"roofing_material_flow": { "value": "99" },
"skin_material_flow": { "value": "99" },
"skin_no_small_gaps_heuristic": { "default_value": true },
"skin_outline_count": { "value": 0 },
"skin_overlap": { "value": "15" },
"skin_overlap_mm": { "value": "0.06" },
"skin_preshrink": { "value": "0.0" },
Expand Down Expand Up @@ -247,6 +246,7 @@
"travel_retract_before_outer_wall": { "default_value": true },
"wall_0_material_flow": { "value": "99" },
"wall_0_wipe_dist": { "value": "0" },
"wall_line_count_skin": { "value": "wall_line_count" },
"wall_material_flow": { "value": "99" },
"wall_thickness": { "value": "1.2" },
"wall_x_material_flow": { "value": "99" },
Expand Down
2 changes: 1 addition & 1 deletion resources/definitions/ultimaker_factor4_plus.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@
"roofing_pattern": { "value": "'lines'" },
"skin_material_flow": { "value": "material_flow * 0.97" },
"skin_material_flow_layer_0": { "value": "material_flow_layer_0 * 0.9" },
"skin_outline_count": { "value": 0 },
"skin_preshrink": { "value": "wall_thickness" },
"skin_support_density": { "value": "material_flow * 0.5" },
"skin_support_speed": { "value": "speed_wall_0" },
Expand Down Expand Up @@ -371,6 +370,7 @@
"top_bottom_pattern": { "value": "'lines'" },
"travel_retract_before_outer_wall": { "value": "'force_not_retracted_from_infill'" },
"wall_0_material_flow_roofing": { "value": "roofing_material_flow" },
"wall_line_count_skin": { "value": "wall_line_count" },
"wall_overhang_angle": { "value": 30 },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_overhang_speed_factors":
Comment thread
wawanbreton marked this conversation as resolved.
{
Expand Down
2 changes: 1 addition & 1 deletion resources/definitions/ultimaker_method_base.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,6 @@
"skin_material_flow": { "value": "material_flow" },
"skin_material_flow_layer_0": { "value": "material_flow" },
Comment thread
wawanbreton marked this conversation as resolved.
"skin_monotonic": { "value": true },
"skin_outline_count": { "value": 0 },
"skin_overlap": { "value": 0 },
"skin_preshrink": { "value": 0 },
"skirt_brim_extruder_nr":
Expand Down Expand Up @@ -740,6 +739,7 @@
"wall_0_material_flow": { "value": "material_flow" },
"wall_0_material_flow_layer_0": { "value": "material_flow" },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_0_wipe_dist": { "value": 0.8 },
"wall_line_count_skin": { "value": "wall_line_count" },
"wall_material_flow": { "value": "material_flow" },
"wall_x_material_flow": { "value": "material_flow" },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_x_material_flow_layer_0": { "value": "material_flow" },
Expand Down
4 changes: 2 additions & 2 deletions resources/definitions/ultimaker_s8.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@
"infill_pattern": { "value": "'zigzag'" },
"infill_sparse_density": { "value": 15 },
"infill_start_end_preference": { "value": "'end_close_to_seam'" },
"infill_wall_line_count": { "value": "1 if infill_sparse_density > 80 else 0" },
"infill_wall_line_count": { "value": "wall_line_count + (1 if infill_sparse_density > 80 else 0)" },
"initial_bottom_layers": { "value": "2 if extruderValueFromContainer(top_bottom_extruder_nr, 'bottom_layers', 2) == bottom_layers else bottom_layers" },
"jerk_flooring":
{
Expand Down Expand Up @@ -456,7 +456,6 @@
"roofing_pattern": { "value": "'lines'" },
"seam_overhang_angle": { "value": 35 },
Comment thread
wawanbreton marked this conversation as resolved.
"skin_material_flow": { "value": 93 },
"skin_outline_count": { "value": 0 },
"skin_preshrink": { "value": 0 },
"skin_support_speed": { "value": "speed_infill * infill_material_flow / skin_support_material_flow" },
"skirt_brim_minimal_length": { "value": 1000 },
Expand Down Expand Up @@ -622,6 +621,7 @@
"wall_0_speed_split_distance": { "value": 0.2 },
"wall_0_start_speed_ratio": { "value": 100 },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_0_wipe_dist": { "value": 0 },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_line_count_skin": { "value": "wall_line_count" },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_material_flow": { "value": 95 },
"wall_overhang_angle": { "value": 45 },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_x_material_flow": { "value": 100 },
Expand Down
2 changes: 1 addition & 1 deletion resources/definitions/ultimaker_sketch_sprint.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@
"skin_material_flow": { "value": "material_flow" },
"skin_material_flow_layer_0": { "value": "material_flow * 0.95" },
Comment thread
wawanbreton marked this conversation as resolved.
"skin_monotonic": { "value": true },
"skin_outline_count": { "value": 0 },
"skin_overlap": { "value": 10 },
"skirt_brim_minimal_length": { "value": 250 },
"skirt_gap": { "value": 1.2 },
Expand Down Expand Up @@ -379,6 +378,7 @@
"wall_0_inset": { "value": "0" },
"wall_0_material_flow_layer_0": { "value": "material_flow * 0.95" },
"wall_0_wipe_dist": { "value": 0.2 },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_line_count_skin": { "value": "wall_line_count" },
"wall_line_width_x": { "value": 0.58 },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_overhang_angle": { "value": 35 },
Comment thread
wawanbreton marked this conversation as resolved.
"wall_overhang_speed_factors":
Comment thread
wawanbreton marked this conversation as resolved.
Expand Down
2 changes: 1 addition & 1 deletion resources/definitions/uni_base.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
"retraction_combing_max_distance": { "value": "10" },
"retraction_min_travel": { "value": "3" },
"skin_line_width": { "value": "round(line_width * 1.0, 2)" },
"skin_outline_count": { "value": "0" },
"skirt_brim_line_width": { "value": "round(line_width * 1.1, 2)" },
"speed_layer_0": { "value": "25" },
"speed_print": { "value": "80" },
Expand All @@ -90,6 +89,7 @@
"top_bottom_pattern": { "value": "'zigzag'" },
"top_bottom_pattern_0": { "value": "'zigzag'" },
"travel_avoid_other_parts": { "value": "False" },
"wall_line_count_skin": { "value": "wall_line_count" },
"z_seam_type": { "value": "'shortest'" },
"zig_zaggify_infill": { "value": "True" }
}
Expand Down
Loading