Cura 8831 autoconf #3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,122 +1,145 @@ | ||||||
| from conan import ConanFile | ||||||
| from conan.tools.env import VirtualBuildEnv | ||||||
| from conan.tools.files import copy, get, rmdir, apply_conandata_patches | ||||||
| from conan.tools.gnu import Autotools, AutotoolsToolchain, AutotoolsDeps | ||||||
| from conan.tools.layout import basic_layout | ||||||
| from conan.tools.microsoft import unix_path, is_msvc | ||||||
|
|
||||||
| required_conan_version = ">=1.51.3" | ||||||
|
|
||||||
|
|
||||||
| class AutoconfConan(ConanFile): | ||||||
| name = "autoconf" | ||||||
| description = "Autoconf is an extensible package of M4 macros that produce shell scripts to automatically configure software source code packages" | ||||||
| license = ("GPL-2.0-or-later", "GPL-3.0-or-later") | ||||||
| url = "https://github.com/conan-io/conan-center-index" | ||||||
| homepage = "https://www.gnu.org/software/autoconf/" | ||||||
| topics = ("autoconf", "configure", "build") | ||||||
| settings = "os", "arch", "compiler", "build_type" | ||||||
|
|
||||||
| @property | ||||||
| def _settings_build(self): | ||||||
| # TODO: Remove for Conan v2 | ||||||
| return getattr(self, "settings_build", self.settings) | ||||||
|
|
||||||
| @property | ||||||
| def win_bash(self): | ||||||
| return self._settings_build.os == "Windows" | ||||||
|
|
||||||
| def export_sources(self): | ||||||
| for p in self.conan_data.get("patches", {}).get(self.version, []): | ||||||
| copy(self, p["patch_file"], self.recipe_folder, self.export_sources_folder) | ||||||
|
|
||||||
| def layout(self): | ||||||
| basic_layout(self, src_folder="autoconf") | ||||||
|
|
||||||
| def requirements(self): | ||||||
| self.requires("m4/1.4.19") | ||||||
|
|
||||||
| def package_id(self): | ||||||
| self.info.clear() | ||||||
|
|
||||||
| def build_requirements(self): | ||||||
| if self._settings_build.os == "Windows" and not self.conf.get("tools.microsoft.bash:path", default=False, check_type=bool): | ||||||
| self.tool_requires("msys2/cci.latest") | ||||||
|
|
||||||
| def source(self): | ||||||
| get(self, **self.conan_data["sources"][self.version], | ||||||
| destination=self.source_folder, strip_root=True) | ||||||
|
|
||||||
| def generate(self): | ||||||
| tc = AutotoolsToolchain(self) | ||||||
| tc.configure_args.extend([ | ||||||
| "--datarootdir=${prefix}/res", | ||||||
| ]) | ||||||
|
|
||||||
| if self.settings.os == "Windows": | ||||||
|
There was a problem hiding this comment. These two statements can be combined
Suggested change
|
||||||
| if is_msvc(self): | ||||||
| build = "{}-{}-{}".format( | ||||||
| "x86_64" if self._settings_build.arch == "x86_64" else "i686", | ||||||
| "pc" if self._settings_build.arch == "x86" else "win64", | ||||||
| "mingw32") | ||||||
| host = "{}-{}-{}".format( | ||||||
| "x86_64" if self.settings.arch == "x86_64" else "i686", | ||||||
| "pc" if self.settings.arch == "x86" else "win64", | ||||||
| "mingw32") | ||||||
| tc.configure_args.append(f"--build={build}") | ||||||
| tc.configure_args.append(f"--host={host}") | ||||||
|
|
||||||
| env = tc.environment() | ||||||
| env.define("INSTALL", unix_path(self, str(self.source_path.joinpath('build-aux', 'install-sh')))) | ||||||
| tc.generate(env) | ||||||
|
|
||||||
| deps = AutotoolsDeps(self) | ||||||
| deps.generate() | ||||||
|
|
||||||
| ms = VirtualBuildEnv(self) | ||||||
| ms.generate(scope="build") | ||||||
|
|
||||||
| def build(self): | ||||||
| apply_conandata_patches(self) | ||||||
|
|
||||||
| autotools = Autotools(self) | ||||||
| autotools.configure() | ||||||
| autotools.make() | ||||||
|
|
||||||
| def package(self): | ||||||
| autotools = Autotools(self) | ||||||
| autotools.install(args=[f"DESTDIR={unix_path(self, self.package_folder)}"]) # Need to specify the `DESTDIR` as a Unix path, aware of the subsystem | ||||||
|
|
||||||
| copy(self, "COPYING*", src=self.source_folder, dst=self.package_path.joinpath("licenses")) | ||||||
| rmdir(self, self.package_path.joinpath("res", "info")) | ||||||
| rmdir(self, self.package_path.joinpath("res", "man")) | ||||||
|
|
||||||
| def package_info(self): | ||||||
| self.cpp_info.libdirs = [] | ||||||
| self.cpp_info.includedirs = [] | ||||||
|
|
||||||
| bin_path = self.package_path.joinpath("bin") | ||||||
| self.output.info(f"Appending PATH environment variable: {bin_path}") | ||||||
| self.env_info.PATH.append(str(bin_path)) | ||||||
|
|
||||||
| dataroot_path = self.package_path.joinpath("res", "autoconf") | ||||||
| self.output.info(f"Defining AC_MACRODIR environment variable: {dataroot_path}") | ||||||
| self.env_info.AC_MACRODIR = str(dataroot_path) | ||||||
| self.buildenv_info.define_path("AC_MACRODIR", str(dataroot_path)) | ||||||
|
|
||||||
| self.output.info(f"Defining AUTOM4TE_PERLLIBDIR environment variable: {dataroot_path}") | ||||||
| self.env_info.AUTOM4TE_PERLLIBDIR = str(dataroot_path) | ||||||
| self.buildenv_info.define_path("AUTOM4TE_PERLLIBDIR", str(dataroot_path)) | ||||||
|
|
||||||
| autoconf_bin = bin_path.joinpath("autoconf") | ||||||
| self.output.info(f"Defining AUTOCONF environment variable: {autoconf_bin}") | ||||||
| self.env_info.AUTOCONF = str(autoconf_bin) | ||||||
| self.buildenv_info.define_path("AUTOCONF", str(autoconf_bin)) | ||||||
|
|
||||||
| autoconf_bin_conf_key = "tools.autoconf:autoconf" | ||||||
| self.output.info(f"Defining path to autoconf binary in configuration as `{autoconf_bin_conf_key}` with value: {autoconf_bin}") | ||||||
| self.conf_info.define(autoconf_bin_conf_key, str(autoconf_bin)) | ||||||
|
|
||||||
| autoreconf_bin = bin_path.joinpath("autoreconf") | ||||||
| self.output.info(f"Defining AUTORECONF environment variable: {autoreconf_bin}") | ||||||
| self.env_info.AUTORECONF = str(autoreconf_bin) | ||||||
| self.buildenv_info.define_path("AUTORECONF", str(autoreconf_bin)) | ||||||
|
|
||||||
| autoreconf_bin_conf_key = "tools.autoconf:autoreconf" | ||||||
| self.output.info(f"Defining path to autoreconf binary in configuration as `{autoreconf_bin_conf_key}` with value: {autoreconf_bin}") | ||||||
| self.conf_info.define(autoreconf_bin_conf_key, str(autoreconf_bin)) | ||||||
|
|
||||||
| autoheader_bin = bin_path.joinpath("autoheader") | ||||||
| self.output.info(f"Defining AUTOHEADER environment variable: {autoheader_bin}") | ||||||
| self.env_info.AUTOHEADER = str(autoheader_bin) | ||||||
| self.buildenv_info.define_path("AUTOHEADER", str(autoheader_bin)) | ||||||
|
|
||||||
| autoheader_bin_conf_key = "tools.autoconf:autoheader" | ||||||
| self.output.info(f"Defining path to autoheader binary in configuration as `{autoheader_bin_conf_key}` with value: {autoheader_bin}") | ||||||
| self.conf_info.define(autoheader_bin_conf_key, str(autoheader_bin)) | ||||||
|
|
||||||
| autom4te_bin = bin_path.joinpath("autom4te") | ||||||
| self.output.info(f"Defining AUTOM4TE environment variable: {autom4te_bin}") | ||||||
| self.env_info.AUTOM4TE = str(autom4te_bin) | ||||||
| self.buildenv_info.define_path("AUTOM4TE", str(autom4te_bin)) | ||||||
|
|
||||||
| autom4te_bin_conf_key = "tools.autoconf:autom4te" | ||||||
| self.output.info(f"Defining path to autom4te binary in configuration as `{autom4te_bin_conf_key}` with value: {autom4te_bin}") | ||||||
| self.conf_info.define(autom4te_bin_conf_key, str(autom4te_bin)) | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,47 +1,53 @@ | ||||||
| import shutil | ||||||
| from os import path | ||||||
|
|
||||||
| from conan import ConanFile | ||||||
| from conan.tools.build import can_run | ||||||
| from conan.tools.gnu import Autotools | ||||||
| from conan.tools.microsoft import unix_path | ||||||
|
|
||||||
| required_conan_version = ">=1.50.0" | ||||||
|
There was a problem hiding this comment.
Suggested change
Not necessary, just suggested since it is easy to commit. |
||||||
|
|
||||||
|
|
||||||
| class TestPackageConan(ConanFile): | ||||||
| settings = "os", "compiler", "build_type", "arch" | ||||||
| exports_sources = "configure.ac", "config.h.in", "Makefile.in", "test_package_c.c", "test_package_cpp.cpp", | ||||||
| generators = "AutotoolsDeps", "AutotoolsToolchain", "VirtualBuildEnv" | ||||||
| test_type = "explicit" | ||||||
|
|
||||||
| @property | ||||||
| def _settings_build(self): | ||||||
| # TODO: Remove for Conan v2 | ||||||
| return getattr(self, "settings_build", self.settings) | ||||||
|
|
||||||
| @property | ||||||
| def win_bash(self): | ||||||
| return self._settings_build.os == "Windows" | ||||||
|
|
||||||
| def build_requirements(self): | ||||||
| if self._settings_build.os == "Windows" and not self.conf.get("tools.microsoft.bash:path", default=False, check_type=bool): | ||||||
| self.tool_requires("msys2/cci.latest") # The conf `tools.microsoft.bash:path` and `tools.microsoft.bash:subsystem` aren't injected for test_package | ||||||
| self.tool_requires(self.tested_reference_str) | ||||||
|
|
||||||
| def build(self): | ||||||
| if self._settings_build.os == "Windows" and not self.conf.get("tools.microsoft.bash:path", default=False, check_type=bool): | ||||||
| return # autoconf needs a bash if there isn't a bash no need to build | ||||||
|
|
||||||
| for src in self.exports_sources: | ||||||
| shutil.copy(path.join(self.source_folder, src), self.build_folder) | ||||||
|
|
||||||
| self.run(f"autoconf --verbose", env="conanbuild") | ||||||
|
There was a problem hiding this comment. Does not need to be a f-string
Suggested change
|
||||||
|
|
||||||
| autotools = Autotools(self) | ||||||
| autotools.configure(build_script_folder=self.build_folder) | ||||||
| autotools.make() | ||||||
|
|
||||||
| def test(self): | ||||||
| if self._settings_build.os == "Windows" and not self.conf.get("tools.microsoft.bash:path", default=False, check_type=bool): | ||||||
| return # autoconf needs a bash if there isn't a bash no need to build | ||||||
|
|
||||||
| if can_run(self): | ||||||
| ext = ".exe" if self.settings.os == "Windows" else "" | ||||||
| test_cmd = unix_path(self, path.join(self.build_folder, f"test_package{ext}")) | ||||||
|
|
||||||
| self.run(test_cmd, env="conanbuild") | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # @configure_input@ | ||
|
|
||
| SRCS = test_package_c.c test_package_cpp.cpp | ||
|
|
||
| OBJS := $(patsubst %.c,%.@OBJEXT@,$(patsubst %.cpp,%.@OBJEXT@,$(SRCS))) | ||
|
|
||
| test_package@EXEEXT@: $(OBJS) | ||
| @CXX@ @CXXFLAGS@ @LDFLAGS@ $^ -o $@ | ||
|
|
||
| %.@OBJEXT@: %.cpp | ||
| @CXX@ @CXXFLAGS@ @CPPFLAGS@ -c $< @CC_MINUS_O@ $@ | ||
|
|
||
| %.@OBJEXT@: %.c | ||
| @CC@ @CFLAGS@ @CPPFLAGS@ -c $< @CC_MINUS_O@ $@ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can just be a property; conan will only apply the setting if OS=windows
https://docs.conan.io/en/latest/systems_cross_building/windows_subsystems.html#self-win-bash