-
Notifications
You must be signed in to change notification settings - Fork 850
[HDRP] Opening the first room of HDRP Template #8156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Looks like reflection probe from the dome interior is leaking into the pier and causing some tiled artifacts.
Otherwise looks great!
Purpose of this PR
After discussing with Mathieu Muller, we had the idea of opening the main room to be able to see more the "recent" environment effects / features. (Water, Cloud Layer, Volumetric Clouds, Atmospheric Scattering, Volumetric Fog).
To be able to do that, With the help of @ValentinHume, the door on the other side has been duplicated to be able to access à small concrete pier.
In addition to that, there's a few things that has been done to the template as well:
And lighting have been rebaked.
Testing status
Opened the template with Unity 6.0, 6.1, 6.2, 6.3 to make sure nothing was broken.
Comments to reviewers
I know there's graphic tests with this project so I need to probably updated those as well.
We're open to suggestions if needed.