-
Notifications
You must be signed in to change notification settings - Fork 21
fix concurrency issue #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ import ( | |
"net" | ||
"regexp" | ||
"strings" | ||
"sync" | ||
"time" | ||
) | ||
|
||
|
@@ -57,6 +58,7 @@ type Client struct { | |
notify chan Notification | ||
disconnect chan struct{} | ||
res []string | ||
mutex sync.Mutex | ||
|
||
Server *ServerMethods | ||
} | ||
|
@@ -234,7 +236,15 @@ func (c *Client) ExecCmd(cmd *Cmd) ([]string, error) { | |
return nil, ErrNotConnected | ||
} | ||
|
||
c.work <- cmd.String() | ||
c.mutex.Lock() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm in too minds if we want to do this, it adds the lock overhead to a client which can only perform one request at a time. This falls under the remit of nothing being concurrent safe unless documented to be so. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can try to think of a better solution to solve this but it should definitely be concurrent safe imho (the fact that two people reported the issue suggests that it's expected despite not being "documented to be so"). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My issue doesn't come from trying to use the library from multiple goroutines at once. My issue happens once unhandled timeout/connection closed errors occur. (for example: Because the next time I execute a command on that closed connection, the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. enabling keepalive on the connection should fix this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
defer c.mutex.Unlock() | ||
|
||
select { | ||
case c.work <- cmd.String(): | ||
// continue | ||
case <-time.After(c.timeout): | ||
return nil, ErrTimeout | ||
} | ||
|
||
select { | ||
case err := <-c.err: | ||
|
Uh oh!
There was an error while loading. Please reload this page.