UnityAds adapter: context handling (GH-3077) + null/empty token to failure by vishaldhiman-unity · Pull Request #30 · Unity-Technologies/googleads-mobile-android-mediation

vishaldhiman-unity · 2026-07-09T16:29:35Z

Separates two Unity Ads adapter fixes from the delayed v4.19.0 fork-sync/new-API migration PR, so they can ship independently off main.

Context handling (GH-3077): pass a nullable Activity to the Unity SDK on show instead of hard-rejecting non-Activity contexts; drop unused ERROR_MSG_CONTEXT_NULL.
Null/empty bidding token to failure: collectSignals treated a null/empty token as an empty success (billed as a no-fill). Route null/empty tokens to SignalCallbacks.onFailure via RoutingTokenListener (new error code 112).

Tests: ./gradlew :unity:test passes.

Pass a nullable Activity to the Unity SDK instead of hard-rejecting a non-Activity context on show. Removes the unused ERROR_MSG_CONTEXT_NULL. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

collectSignals treated a null/empty token as an empty success, so the bidder billed Unity as a no-fill. Route null/empty tokens to SignalCallbacks.onFailure via RoutingTokenListener (new error code 112). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Copilot

Pull request overview

This PR extracts and ships two Unity Ads adapter fixes independently: (1) relaxes show-time context handling by passing a nullable Activity into the Unity SDK instead of hard-failing non-Activity contexts, and (2) treats null/empty RTB bidding tokens as an error by routing them to SignalCallbacks.onFailure (new adapter error code 112) rather than reporting an “empty success”.

Changes:

Update interstitial + rewarded showAd to pass Activity? (null when context is not an Activity) to UnityAds.show(...).
Add RoutingTokenListener to route null/empty tokens to SignalCallbacks.onFailure with ERROR_TOKEN_GENERATION_FAILED = 112.
Update/add unit tests covering the new context behavior and null/empty token failure routing.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
ThirdPartyAdapters/unity/unity/src/main/java/com/google/ads/mediation/unity/UnityRewardedAd.java	Allow show with non-`Activity` context by passing nullable `Activity` to Unity show.
ThirdPartyAdapters/unity/unity/src/main/java/com/google/ads/mediation/unity/UnityInterstitialAd.java	Same nullable-`Activity` show behavior for interstitial.
ThirdPartyAdapters/unity/unity/src/main/java/com/google/ads/mediation/unity/UnityMediationAdapter.java	Route null/empty RTB token to `onFailure` via new `RoutingTokenListener` and error code 112.
ThirdPartyAdapters/unity/unity/src/test/kotlin/com/google/ads/mediation/unity/UnityRewardedAdTest.kt	Update show-context test to expect Unity show called with `null` activity.
ThirdPartyAdapters/unity/unity/src/test/kotlin/com/google/ads/mediation/unity/UnityInterstitialAdTest.kt	Add show-context test to expect Unity show called with `null` activity.
ThirdPartyAdapters/unity/unity/src/test/kotlin/com/google/ads/mediation/unity/UnityMediationAdapterTest.kt	Add tests asserting null/empty tokens route to `SignalCallbacks.onFailure`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

AnwarissaAsbah · 2026-07-13T18:30:41Z

is the following check still needed? In public api migration PR, we were able to remove it

if (adFormat == AdFormat.BANNER && !(rtbSignalData.getContext() instanceof Activity)) {                
   signalCallbacks.onFailure(new AdError(ERROR_CONTEXT_NOT_ACTIVITY,                         
     "Unity Ads RTB Banner ads require activity context", ADAPTER_ERROR_DOMAIN));                  
   return;                                                      
 }

vishaldhiman-unity · 2026-07-15T20:59:37Z

is the following check still needed? In public api migration PR, we were able to remove it

if (adFormat == AdFormat.BANNER && !(rtbSignalData.getContext() instanceof Activity)) {                
   signalCallbacks.onFailure(new AdError(ERROR_CONTEXT_NOT_ACTIVITY,                         
     "Unity Ads RTB Banner ads require activity context", ADAPTER_ERROR_DOMAIN));                  
   return;                                                      
 }

As discussed will remove thanks.

BannerView accepts a plain Context since Unity Ads SDK 4.16.2, so drop the Activity checks in collectSignals and the banner load path and pass the context through directly. Also tighten the RoutingTokenListener Javadoc to the implemented behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

vishaldhiman-unity · 2026-07-15T22:28:18Z

Good catch on the banner Activity-context check, fixed it in a0ce9fa. BannerView accepts a plain Context since 4.16.2, so removed the Activity requirement from the banner load path too.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

No longer referenced after dropping the Activity-context requirements. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

…ivity test Copilot flagged that the test only checked onSuccess() and would still pass if onFailure or other callbacks were also invoked. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

bichenwang

lgtm otherwise

bichenwang · 2026-07-17T11:56:30Z

-
-  static final String ERROR_MSG_NON_ACTIVITY =
-      "Unity Ads requires an Activity context to load ads.";
+  /** UnityAds returned no usable bidding token; routed to onFailure so the bidder skips Unity. */


super nit: format this line

bichenwang · 2026-07-17T11:59:09Z

+        signalCallbacks.onFailure(
+            new AdError(
+                ERROR_TOKEN_GENERATION_FAILED,
+                "Unity Ads returned a null or empty bidding token.",


the other errors have a named constant for an error message. should we do the same?

vishaldhiman-unity and others added 2 commits July 8, 2026 11:45

UnityAds adapter: handle non-Activity context on show (GH-3077)

5c00f1a

Pass a nullable Activity to the Unity SDK instead of hard-rejecting a non-Activity context on show. Removes the unused ERROR_MSG_CONTEXT_NULL. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

vishaldhiman-unity requested a review from Copilot July 9, 2026 17:32

Copilot started reviewing on behalf of vishaldhiman-unity July 9, 2026 17:32 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread ...Adapters/unity/unity/src/main/java/com/google/ads/mediation/unity/UnityMediationAdapter.java Outdated

vishaldhiman-unity marked this pull request as ready for review July 13, 2026 17:33

vishaldhiman-unity requested review from AnwarissaAsbah and Copilot July 15, 2026 23:26

Copilot started reviewing on behalf of vishaldhiman-unity July 15, 2026 23:27 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread ...Adapters/unity/unity/src/main/java/com/google/ads/mediation/unity/UnityMediationAdapter.java

Comment thread ...Adapters/unity/unity/src/main/java/com/google/ads/mediation/unity/UnityMediationAdapter.java Outdated

vishaldhiman-unity and others added 2 commits July 16, 2026 09:00

Potential fix for pull request finding

eea4fd8

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Remove unused ERROR_CONTEXT_NOT_ACTIVITY and ERROR_MSG_NON_ACTIVITY

3fe5a2e

No longer referenced after dropping the Activity-context requirements. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

vishaldhiman-unity requested a review from Copilot July 16, 2026 18:27

Copilot started reviewing on behalf of vishaldhiman-unity July 16, 2026 18:28 View session

Copilot AI reviewed Jul 16, 2026

View reviewed changes

Comment thread ...ters/unity/unity/src/test/kotlin/com/google/ads/mediation/unity/UnityMediationAdapterTest.kt

Address PR feedback: assert no unexpected callbacks in banner non-Act…

7ce21a7

…ivity test Copilot flagged that the test only checked onSuccess() and would still pass if onFailure or other callbacks were also invoked. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

vishaldhiman-unity requested a review from a team July 16, 2026 18:46

bichenwang approved these changes Jul 17, 2026

View reviewed changes

vishaldhiman-unity merged commit 5377ed1 into main Jul 17, 2026
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

UnityAds adapter: context handling (GH-3077) + null/empty token to failure#30

UnityAds adapter: context handling (GH-3077) + null/empty token to failure#30
vishaldhiman-unity merged 6 commits into
mainfrom
fix/unity-adapter-token-and-context

vishaldhiman-unity commented Jul 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

AnwarissaAsbah commented Jul 13, 2026

Uh oh!

vishaldhiman-unity commented Jul 15, 2026

Uh oh!

vishaldhiman-unity commented Jul 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

bichenwang left a comment

Uh oh!

bichenwang Jul 17, 2026

Uh oh!

bichenwang Jul 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

vishaldhiman-unity commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

AnwarissaAsbah commented Jul 13, 2026

Uh oh!

vishaldhiman-unity commented Jul 15, 2026

Uh oh!

vishaldhiman-unity commented Jul 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

bichenwang left a comment

Choose a reason for hiding this comment

Uh oh!

bichenwang Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

bichenwang Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vishaldhiman-unity commented Jul 9, 2026 •

edited

Loading