Skip to content

Upgrade grpcio version #6208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 13, 2025
Merged

Upgrade grpcio version #6208

merged 16 commits into from
Jun 13, 2025

Conversation

maryamziaa
Copy link
Contributor

@maryamziaa maryamziaa commented Jun 10, 2025

Proposed change(s)

Describe the changes made in this PR.
Upgrade grpcio Python binary wheels since grpcio 1.48.2 doesn't come with precompiled binaries to be used with Apple M1. Ref: grpc/grpc#34821 (comment)

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe): Update grpcio library version in setup.py

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@CLAassistant
Copy link

CLAassistant commented Jun 10, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the grpcio dependency version to support Apple M1 machines by expanding the upper version limit and removes outdated OS X installation instructions for grpc.

  • Update grpcio version range to <=1.51.3 in ml-agents/setup.py and ml-agents-envs/setup.py
  • Remove obsolete OS X GRPC library installation instructions from docs/Installation.md

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
ml-agents/setup.py Updated grpcio dependency version range for Apple M1 support
ml-agents-envs/setup.py Synced grpcio dependency version update
docs/Installation.md Removed outdated OS X GRPC installation instructions
Comments suppressed due to low confidence (1)

docs/Installation.md:167

  • The removal of the manual GRPC installation instructions is appropriate given the updated grpcio wheels; however, consider referencing this change in the upgrade notes or documentation to guide users upgrading from previous versions.
#### (OS X) Installing GRPC libraries [removed block]

@maryamziaa maryamziaa merged commit 39f4e42 into develop Jun 13, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants