Extend oop api2 #2123
Merged
Extend oop api2 #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joncham
reviewed
Apr 2, 2025
joncham
reviewed
Apr 2, 2025
mono/metadata/oop.c
Outdated
| @@ -425,6 +470,11 @@ mono_unity_oop_get_stack_frame_details( | |||
| frameDetails->assemblyNameLen, | |||
| read_pointer(OFFSET_MEMBER(MonoImage, image, assembly_name))); | |||
|
|
|||
| frameDetails->assemblyNameLen = read_nt_string( | |||
There was a problem hiding this comment.
I think this is a copy/paste error, and you want to assign to assemblyFileNameLen?
joncham
reviewed
Apr 2, 2025
mono/metadata/oop.c
Outdated
|
|
||
| // the line below will lead to access violation as code_start point to non-initialized memory | ||
| // so probably oop_jit_info_table_find above didn't fully intitialized ji ? | ||
| gpointer code_starts = ji->code_start; |
There was a problem hiding this comment.
The ji is a pointer in the address space of another process. You likely need:
gpointer code_starts = read_pointer(OFFSET_MEMBER(MonoJitInfo, ji, code_start));
MindWrapper
commented
Apr 2, 2025
mono/metadata/oop.c
Outdated
| // so probably oop_jit_info_table_find above didn't fully intitialized ji ? | ||
| gpointer code_starts = read_pointer(OFFSET_MEMBER(MonoJitInfo, ji, code_start)); | ||
|
|
||
| gint32 relative_address = (gint32)((char*)frameAddress - (char*)code_starts); |
There was a problem hiding this comment.
@joncham now relative_address work correctly, however hitting this condition.
mono/mono/metadata/mono-debug.c
Line 755 in ad9fb61
I guess we need to add mono_oop_debug_init ? Is that feasible?
Minor md update Initial implementation of mono_unity_oop_debug_lookup_source_location Fix copy-paste error fixed code_start calulation Fix typo remove mono_unity_oop_debug_lookup_source_location Remove unused include Rollback other unnecessary changes
MindWrapper
force-pushed
the
extend-oop-api2
branch
from
98effcd to
23b01e1
Compare
joncham
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture assembly file name
Reviewers: please consider these questions as well! ❤️
Release notes
Internal
https://github.cds.internal.unity3d.com/unity/unity/pull/66061