Extend oop api2 #2123
Extend oop api2 #2123
Conversation
|
|
| @@ -14,7 +14,8 @@ | |||
|
|
|||
| #### Runtime | |||
| From the root of your cloned mono directory run: | |||
| - external\buildscripts\build_runtime_win.pl | |||
| - external\buildscripts\build_runtime_win64.pl | |||
mono/metadata/oop.c
Outdated
| @@ -425,6 +470,11 @@ mono_unity_oop_get_stack_frame_details( | |||
| frameDetails->assemblyNameLen, | |||
| read_pointer(OFFSET_MEMBER(MonoImage, image, assembly_name))); | |||
|
|
|||
| frameDetails->assemblyNameLen = read_nt_string( | |||
There was a problem hiding this comment.
I think this is a copy/paste error, and you want to assign to assemblyFileNameLen?
mono/metadata/oop.c
Outdated
|
|
||
| // the line below will lead to access violation as code_start point to non-initialized memory | ||
| // so probably oop_jit_info_table_find above didn't fully intitialized ji ? | ||
| gpointer code_starts = ji->code_start; |
There was a problem hiding this comment.
The ji is a pointer in the address space of another process. You likely need:
gpointer code_starts = read_pointer(OFFSET_MEMBER(MonoJitInfo, ji, code_start));
| // so probably oop_jit_info_table_find above didn't fully intitialized ji ? | ||
| gpointer code_starts = read_pointer(OFFSET_MEMBER(MonoJitInfo, ji, code_start)); | ||
|
|
||
| gint32 relative_address = (gint32)((char*)frameAddress - (char*)code_starts); |
There was a problem hiding this comment.
@joncham now relative_address work correctly, however hitting this condition.
mono/mono/metadata/mono-debug.c
Line 755 in ad9fb61
I guess we need to add mono_oop_debug_init ? Is that feasible?
Reviewers: please consider these questions as well! ❤️
Release notes
Fixed UUM-XXXXXX @username:
Mono: Your release notes go here.