Skip to content

Conversation

URJala
Copy link
Collaborator

@URJala URJala commented Aug 5, 2025

Changes all our realtime_tools containers to RealtimeThreadSafeBox, seems like that is fine everywhere.
Also made it so that any reading or writing done outside of real-time threads will retry 10 times before failing.

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 0% with 220 lines in your changes missing coverage. Please review.
✅ Project coverage is 5.08%. Comparing base (1b121b7) to head (dd7afa9).
⚠️ Report is 486 commits behind head on main.

Files with missing lines Patch % Lines
...trollers/src/passthrough_trajectory_controller.cpp 0.00% 150 Missing ⚠️
ur_controllers/src/tool_contact_controller.cpp 0.00% 50 Missing ⚠️
ur_controllers/src/force_mode_controller.cpp 0.00% 12 Missing ⚠️
ur_controllers/src/ur_configuration_controller.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1474      +/-   ##
========================================
+ Coverage   3.59%   5.08%   +1.49%     
========================================
  Files         13      33      +20     
  Lines        947    3421    +2474     
  Branches     152     429     +277     
========================================
+ Hits          34     174     +140     
- Misses       843    3245    +2402     
+ Partials      70       2      -68     
Flag Coverage Δ
unittests 5.08% <0.00%> (+1.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@URJala URJala requested a review from urfeex August 5, 2025 12:54
@urfeex urfeex force-pushed the realtime_tools_migration branch from 3c07a1b to 333918e Compare September 10, 2025 15:29
@urfeex urfeex force-pushed the realtime_tools_migration branch from 333918e to 586d9c7 Compare September 15, 2025 09:57
@urfeex urfeex merged commit 76b3e37 into UniversalRobots:main Sep 16, 2025
11 of 14 checks passed
mergify bot pushed a commit that referenced this pull request Sep 16, 2025
Use RealtimeThreadSafeBox instead of RealTimeBuffer.

Also made it so that any reading or writing done outside of real-time threads will retry 10 times before failing in non-RT contexts.

(cherry picked from commit 76b3e37)

# Conflicts:
#	ur_controllers/include/ur_controllers/force_mode_controller.hpp
urfeex pushed a commit that referenced this pull request Sep 16, 2025
…1501)

Use RealtimeThreadSafeBox instead of RealTimeBuffer.

Also made it so that any reading or writing done outside of real-time threads will retry 10 times before failing in non-RT contexts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants