-
Notifications
You must be signed in to change notification settings - Fork 295
Realtime tools migration #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Realtime tools migration #1474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1474 +/- ##
========================================
+ Coverage 3.59% 5.08% +1.49%
========================================
Files 13 33 +20
Lines 947 3421 +2474
Branches 152 429 +277
========================================
+ Hits 34 174 +140
- Misses 843 3245 +2402
+ Partials 70 2 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3c07a1b
to
333918e
Compare
333918e
to
586d9c7
Compare
urfeex
approved these changes
Sep 16, 2025
mergify bot
pushed a commit
that referenced
this pull request
Sep 16, 2025
Use RealtimeThreadSafeBox instead of RealTimeBuffer. Also made it so that any reading or writing done outside of real-time threads will retry 10 times before failing in non-RT contexts. (cherry picked from commit 76b3e37) # Conflicts: # ur_controllers/include/ur_controllers/force_mode_controller.hpp
urfeex
pushed a commit
that referenced
this pull request
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes all our
realtime_tools
containers toRealtimeThreadSafeBox
, seems like that is fine everywhere.Also made it so that any reading or writing done outside of real-time threads will retry 10 times before failing.