Fix assumed first variable, myradio API is actually "secs"#306
Merged
ashhhleyyy merged 1 commit intomasterfrom Oct 17, 2025
Merged
Fix assumed first variable, myradio API is actually "secs"#306ashhhleyyy merged 1 commit intomasterfrom
ashhhleyyy merged 1 commit intomasterfrom
Conversation
Member
|
I'm guessing it worked before we upgraded to PHP 8 and it started actually caring about the names of variables :) |
markspolakovs
approved these changes
Oct 15, 2025
Member
|
Over to @ashhhleyyy for merging, feels wrong of me to do it now :) |
Member
|
ffs I'm too used to gitlab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/UniversityRadioYork/MyRadio/blob/master/src/Classes/NIPSWeb/NIPSWeb_TimeslotItem.php#L119
PHP must have used to just assumed what I wanted!