Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration possibilities for CORS middleware #705

Merged
merged 9 commits into from
Feb 6, 2025

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Feb 3, 2025

Reported in #701 - Edge currently is set to Allow-Any-Origin (*). the Issue requests the possibility to lock it down more than this.

This PR uses the same configuration variables available in Unleash Proxy: https://docs.getunleash.io/reference/unleash-proxy#configuration-options but excludes the ones that are not supported by our actix-cors middleware.

fixes #701

@chriswk chriswk requested a review from sighphyre February 3, 2025 14:08
@chriswk chriswk self-assigned this Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chriswk chriswk merged commit bf4360e into main Feb 6, 2025
17 checks passed
@chriswk chriswk deleted the task/addSpecificCorsSupport branch February 6, 2025 08:22
This was referenced Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

can we add whitelisted domain for unleash edge instance
2 participants