feat: upgrade logging level of serialization errors to actual errors #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
| @@ -347,7 +349,7 @@ impl FeatureRefresher { | |||
|
|
|||
| match serde_json::from_str(&event.data) { | |||
| Ok(features) => { refresher.handle_client_features_updated(&token, features, None).await; } | |||
| Err(e) => { warn!("Could not parse features response to internal representation: {e:?}"); | |||
| Err(e) => { tracing::error!("Could not parse features response to internal representation: {e:?}"); | |||
There was a problem hiding this comment.
Ok, this is the relevant change, shouldn't we use the same match serde_json::from_str in line 424 and 425 when reading deltas?
gastonfournier
approved these changes
Feb 10, 2025
This was referenced Feb 10, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an incident over the weekend where our sandbox instances weren't being updated due to the features response not being parsed, but since it was logged at warn we did not get any notices about this in Slack. This PR upgrades the logging level of parse errors for SSE to error so that our error alerting can trigger and we can know that our upstream is returning invalid data.