feat: create and edit environment required approvals #9621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
kwasniew
commented
Mar 26, 2025
| @@ -198,7 +198,7 @@ export interface IEnvironment { | |||
| projectCount?: number; | |||
| apiTokenCount?: number; | |||
| enabledToggleCount?: number; | |||
| requiredApprovals?: number; | |||
| requiredApprovals?: number | null; | |||
There was a problem hiding this comment.
we have to distinguish null and undefined. undefined means skip this field in update and keep the previous value, null means reset this field to null in update
kwasniew
commented
Mar 26, 2025
| <StyledRequiredApprovals> | ||
| Required approvals | ||
| </StyledRequiredApprovals> | ||
| <GeneralSelect |
There was a problem hiding this comment.
copied from the table with change request settings
kwasniew
commented
Mar 26, 2025
| marginBottom: theme.spacing(0.5), | ||
| })); | ||
|
|
||
| const useApprovalOptions = () => { |
There was a problem hiding this comment.
copied from change requests table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Can create and edit environment with required change request approvals
Details:
Important files
Discussion points