Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add password with PDF files #3721

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add password with PDF files #3721

wants to merge 12 commits into from

Conversation

pprados
Copy link

@pprados pprados commented Oct 15, 2024 •
edited
Loading

Add password with PDF files
Must be combined with PR 392 in unstructured-inference

@pprados pprados mentioned this pull request Oct 15, 2024
Open
@pprados pprados marked this pull request as ready for review October 15, 2024 12:20
@pprados
Copy link
Author

pprados commented Oct 24, 2024

@plutasnyy can you activate the revue process ?

@plutasnyy
Copy link
Contributor

Sure! Could you add some unit tests? Ideally some PDF with password that is not extractable with current main code.

Please also bump the __version__ and changelog.md you see example in other PRs for example https://github.com/Unstructured-IO/unstructured/pull/3734/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR1

@pprados
Copy link
Author

pprados commented Oct 24, 2024

@plutasnyy Done. I add TU.

@pprados
Copy link
Author

pprados commented Oct 25, 2024

@plutasnyy can you test again ?

@pprados
Copy link
Author

pprados commented Nov 25, 2024

@plutasnyy, can you revue the code ?

@pprados
Merge remote-tracking branch 'origin/main' into pprados/fix_password
6f54d3f 
# Conflicts:
#	requirements/ingest/ingest.txt
#	test_unstructured/partition/pdf_image/test_pdf.py
#	unstructured/partition/pdf.py
#	unstructured/partition/pdf_image/pdfminer_processing.py
@pprados
Merge with the last version
09f7c40
@pprados
Merge branch 'main' into pprados/fix_password
2b1a401
@pprados
Copy link
Author

pprados commented Dec 9, 2024 •
edited
Loading

@cragwolfe or @plutasnyy

Can you approval these workflow ?

@Coniferish
Copy link
Collaborator

Hi @pprados! Thanks for making this contribution and following up with us. I have some other issues I'm working on right now, but intend to take a look at these changes later this week.

@pprados
Copy link
Author

pprados commented Jan 15, 2025

Super ! I will rebase my PR quickly

@pprados
Copy link
Author

pprados commented Jan 15, 2025

May be can approve this PR, like this I can verify that the PR passes the CI/CD. Otherwise, you must validate each modification I publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinestraub christinestraub Awaiting requested review from christinestraub

@Coniferish Coniferish Awaiting requested review from Coniferish

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pprados @plutasnyy @Coniferish