Conversation
badGarnet
reviewed
Mar 3, 2026
| # -- on some environments libmagic can return a generic/unhelpful MIME-type | ||
| # -- like octet-stream") for files that the `filetype` package identify. | ||
| # -- when that happens we retry using `filetype` `FileType.UNK` results. | ||
| if LIBMAGIC_AVAILABLE: |
Collaborator
There was a problem hiding this comment.
we only need to call this when file_type == FileType.UNK and LIBMAGIC_AVAILABLE, right?
Contributor
Author
There was a problem hiding this comment.
Yes - only cases where libmagic is already available but failed to get the right file
-
mime_type is not None (otherwise the function already returned None), and
-
FileType.from_mime_type(mime_type) returned FileType.UNK, and
-
LIBMAGIC_AVAILABLE is True.
qued
approved these changes
Mar 3, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.