fix: extract <details> and <summary> accordion content#4278
Closed
AlonNaor22 wants to merge 1 commit intoUnstructured-IO:mainfrom
Closed
fix: extract <details> and <summary> accordion content#4278AlonNaor22 wants to merge 1 commit intoUnstructured-IO:mainfrom
AlonNaor22 wants to merge 1 commit intoUnstructured-IO:mainfrom
Conversation
…carding it The HTML parser mapped <details> and <summary> elements to RemovedBlock, causing all accordion/collapsible content (e.g. FAQ sections) to be silently dropped from partition output. Reclassify both as Flow elements so their text content is properly extracted. Closes #3919 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
partition_htmlsilently discards all content inside<details>and<summary>HTML elements (accordions/collapsible sections)<details>and<summary>were mapped toRemovedBlockin the HTML parser element class lookup, causing them and all their children to be stripped from output<details>asFlow(block container, like<div>) and<summary>asFlow(block element, let text classifier decide the element type)Files changed
unstructured/partition/html/parser.py— changed"details": RemovedBlock→Flowand"summary": RemovedBlock→Flowtest_unstructured/partition/html/test_partition.py— added 6 tests covering: basic<details>,<summary>extraction, FAQ accordion, nested details, details without summary, summary with inline markupTest plan
<details><p>text</p></details>→ content extracted (was empty before)<summary>heading text appears in output<details>elements all extracted<details>without<summary>still works<summary>with inline markup (<b>,<em>) preserves textruff check+ruff format)