First LCR assignment done.#339
Closed
szaboemelitta wants to merge 1 commit intoUofT-DSI:mainfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code and my answers to the assignment-1 Jupiter notebook.
What did you learn from the changes you have made?
I have practiced the learned material/knn model through the assignment.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Generally, it was a bit challenging to understand the workflow, concepts, and put them into practice.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The last step of accuracy_score was a bit challenging, as I didn't know first what to pass into the method.
How were these changes tested?
I run the code and got 0.933 accuracy, but still not sure whether I have done everything correctly.
A reference to a related issue in your repository (if applicable)
Checklist