adding the modified assignment.sh#637
Closed
1joao-vitor-pereira wants to merge 1 commit intoUofT-DSI:mainfrom
Closed
adding the modified assignment.sh#6371joao-vitor-pereira wants to merge 1 commit intoUofT-DSI:mainfrom
1joao-vitor-pereira wants to merge 1 commit intoUofT-DSI:mainfrom
Conversation
|
This pull request was made to the wrong repository. If you are a participant, please close it and open it in your own fork instead. Refer to the Assignment Submission Guide for detailed instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
We are only adding the changes made to assignment.sh on my assignment branch into the main branch.
What did you learn from the changes you have made?
I learned how to run full .sh scripts and how to create them to create, copy, and manipulate files and directories, making repositories ready for future data science projects.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I considered a different approach for the copy step. I thought about simplifying how data is copied instead of separating it into server, user, and event logs, but I wasn’t able to find a better way to implement it.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I had challenges putting the full script together, especially when creating and removing directories. I had to read more about command flags to ensure the script correctly creates parent folders, forces removals when needed, and handles errors properly.
How were these changes tested?
I tested the script locally by repeatedly creating and deleting the project folders on my machine until I confirmed that assignment.sh was producing the expected results.
A reference to a related issue in your repository (if applicable)
Checklist