This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Add capability to use sse encryption: to new properties added to amaz… #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on.properties s3fs_require_encrypt=[true|false] if the bucket require sse encryption s3fs_encrypt_arn=<arn key to use to encrypt the files if not specifed and s3fs_require_encrypt is set to true the default key would be used>
jarnaiz
force-pushed
the
master
branch
2 times, most recently
from
519195e to
9216d8b
Compare
|
Hello @storressa Thanks for your PR but you dont have any test in this PR, we need it in order to accept this PR. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on.properties
s3fs_require_encrypt=[true|false] if the bucket require sse encryption
s3fs_encrypt_arn=