Added support for specifying KMS key ID as s3fs_kms_key_id #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that a full integration test would require the creation of a custom KMS key which would incur a monthly charge. Temporary keys also cannot be deleted until the cool-down period has lapsed. |
17 tasks
|
Hi @thomascollett , I hope you're well! I'm not sure, if you've recieved my e-mail, but just in case -- I'm reaching out here as well. As this project seems to have been abandoned, I was wondering, if you'd be interested in contributing these fixes against our spin-off (rebranded fork) -- s3fs-nio? Kind regards, Martin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for KMS encryption for objects in S3, by specifying the key ID to use. Closes #80 .
Key ID can be specified as an alias (e.g.
alias/mykeyaliasname), by the key's UUID displayed in the IAM console (e.g.abcdef123-1122-3344-5566-1a23456789cd), or by the full ARN (arn:aws:kms:eu-west-1:1234567890:key/abcdef123-1122-3344-5566-1a23456789cd).Have tested the changes against a remote bucket with a custom key and the correct KMS encryption metadata is being set on the objects.