Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA improvements #33

Merged
merged 4 commits into from
Aug 11, 2024
Merged

GHA improvements #33

merged 4 commits into from
Aug 11, 2024

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Aug 10, 2024

  • Fix paths for caching Rust dependencies (CLI generator script #27 broke it)
    • Additionally, make the key depend on Cargo.lock contents (but still using rust_backend as a restore key). Previously we'd been doing it slightly carelessly by having a static key — this means that the cache would never be updated if the dependencies changed
  • Adds caching for pnpm dependencies (minor speedup)
  • Test packages in parallel rather than sequentially — this both speeds things up and also makes it easier to see if something is failing in multiple parts of the codebase
  • Only deploy the website to GitHub Pages if tests pass. This was done by removing the separate web.yml and looping in the deployment step into the other action.
  • This isn't part of the code, but I installed the pre-commit-ci-lite GitHub app on this repo so that the corresponding action would work.

@penelopeysm penelopeysm force-pushed the fix-gha branch 5 times, most recently from 43c0f5a to 0c87c45 Compare August 10, 2024 23:29
@penelopeysm penelopeysm changed the title Fixes for GHA GHA improvements Aug 10, 2024
@penelopeysm penelopeysm force-pushed the fix-gha branch 2 times, most recently from b8e4a5b to 527e44f Compare August 10, 2024 23:54
@penelopeysm penelopeysm force-pushed the fix-gha branch 2 times, most recently from 6ff04dc to d10c322 Compare August 11, 2024 00:00
@penelopeysm
Copy link
Member Author

Runs well on this PR, so will merge.

@penelopeysm penelopeysm merged commit 6eb7041 into main Aug 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant