Separate out classes in object_adapter - #72
Open
hlarsen wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting back to looking at Unidot and since the last time I tried it my asset source has updated some packs to use the URP and ShaderGraph which is causing material creation issues. I broke out the classes in object_adapter.gd and moved them into their own classes to separate things a bit. There should be no logic changes in this PR, just adding class_name and any references they need to other classes; a few lines had to have their typehints commented while moving things around.
There are minor changes to logging and I cleaned up a bit in Material with typehints and comments, but no "real" changes.
Please let me know if any changes would make this easier to review/merge.