Skip to content

refactor: use emit.forEach instead of internal events #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: use emit.forEach instead of internal events #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 13 additions & 32 deletions lib/counter/bloc/counter_bloc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,28 @@ class CounterBloc extends Bloc<CounterEvent, CounterState> {
: _counterRepository = counterRepository,
super(const CounterState()) {
on<CounterStarted>(_onCounterStarted);
on<_CounterConnectionStateChanged>(_onCounterConnectionStateChanged);
on<_CounterCountChanged>(_onCounterCountChanged);
on<CounterIncrementPressed>(_onCounterIncrementPressed);
on<CounterDecrementPressed>(_onCounterDecrementPressed);
}

final CounterRepository _counterRepository;
StreamSubscription<int>? _countSubscription;
StreamSubscription<ConnectionState>? _connectionSubscription;

void _onCounterStarted(
Future<void> _onCounterStarted(
CounterStarted event,
Emitter<CounterState> emit,
) {
_countSubscription = _counterRepository.count.listen(
(count) => add(_CounterCountChanged(count)),
) async {
final countEmitter = emit.forEach<int>(
_counterRepository.count,
onData: (count) =>
state.copyWith(count: count, status: CounterStatus.connected),
);

final connectionEmitter = emit.forEach<ConnectionState>(
_counterRepository.connection,
onData: (state) => this.state.copyWith(status: state.toStatus()),
);
_connectionSubscription = _counterRepository.connection.listen((state) {
add(_CounterConnectionStateChanged(state));
});

await Future.wait([countEmitter, connectionEmitter]);
}

void _onCounterIncrementPressed(
Expand All @@ -47,27 +49,6 @@ class CounterBloc extends Bloc<CounterEvent, CounterState> {
) {
_counterRepository.decrement();
}

void _onCounterConnectionStateChanged(
_CounterConnectionStateChanged event,
Emitter<CounterState> emit,
) {
emit(state.copyWith(status: event.state.toStatus()));
}

void _onCounterCountChanged(
_CounterCountChanged event,
Emitter<CounterState> emit,
) {
emit(state.copyWith(count: event.count, status: CounterStatus.connected));
}

@override
Future<void> close() {
_connectionSubscription?.cancel();
_countSubscription?.cancel();
return super.close();
}
}

extension on ConnectionState {
Expand Down
12 changes: 0 additions & 12 deletions lib/counter/bloc/counter_event.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,3 @@ class CounterIncrementPressed extends CounterEvent {
class CounterDecrementPressed extends CounterEvent {
const CounterDecrementPressed();
}

class _CounterCountChanged extends CounterEvent {
const _CounterCountChanged(this.count);

final int count;
}

class _CounterConnectionStateChanged extends CounterEvent {
const _CounterConnectionStateChanged(this.state);

final ConnectionState state;
}