-
Notifications
You must be signed in to change notification settings - Fork 12
Add miob example config #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
please name the file fpga-miob. The filename should reference the node type the file is an example for. |
I renamed the file. 5a24f6b |
The new config fails in the integration test:
|
@stv0g It looks like the module vfio or vfio-platform can not be loaded on the integration server |
fpga test will always fail because the CI does not have a FPGA. We tested the file offline. Why does fpga.conf work? |
The test will only attempt to parse the configuration. No actual exchange via VFIO needs to take place here. The point is only to verify that the configuration file is semantically correct and can be parsed. |
the parsing shouldn't try to load the vfio kernel module. @IgnoreWarnings can you check what is happening? Maybe you have to separate the device resolution from the parsing. |
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
5168ed2
to
8c2ffc0
Compare
I will look into why this fails, it works on hardware. |
@IgnoreWarnings I see you removed the module loading for |
Yes, I will look at this the next weeks, should be an easy fix. |
097526b
to
8c2ffc0
Compare
Signed-off-by: Pascal Bauer <[email protected]>
8c2ffc0
to
f10fc2c
Compare
@stv0g The creation of a vfio container, which is passed to the fpga factories, requires vfio module, which cannot be loaded on pipeline. Maybe we should just ignore the integration test? |
Okay, thats strange. Ideally, we would be able to defer loading modules to after the configuration parsing. If thats not possible, we could add another exception. But, I think we should first understand why the modules are loadded so early.. |
Add a miob example config for loopback.