-
Notifications
You must be signed in to change notification settings - Fork 11
Add new node-type for OpenDSS #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ca0faff
to
90a7453
Compare
@JitpanuM I think, I got most of the build issues fixed. But there is a problem with the example config and the integration test thereof. Could you have a look? |
It seem like opendss change the working directory to /home/user/OpenDSS. That is why the integration test couldn't find the config file. |
Ouch, that's annoying. Do you already have an idea how we can fix it? |
I think that modifing their source code to set the current working directory back should work. |
6840754
to
111f2bb
Compare
Urgh, we get some flaky / broken integration tests now :( I suspect that something with the timing changed.. Maybe loading the We will need to split-up this PR into smaller ones unfortunately :( |
I moved a bunch of unreleated updates to this PR #893 |
Signed-off-by: Jitpanu Maneeratpongsuk <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Jitpanu Maneeratpongsuk <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Jitpanu Maneeratpongsuk <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Okay, the Docker image updates (#893) have been merged into master, and I have rebased this PR onto it. I also did some cleanup of the Git history. Please reset your local branch before pushing any more changes :) Thanks :) |
Continuation of #887
TODO:
Add integration test
Add OpenAPI spec
Add Documentation