Skip to content

Conversation

@stv0g
Copy link
Contributor

@stv0g stv0g commented Apr 17, 2025

Continuation of #887

TODO:

Add integration test
Add OpenAPI spec
Add Documentation

@stv0g stv0g requested a review from n-eiling as a code owner April 17, 2025 09:29
@stv0g stv0g force-pushed the node-opendss branch 3 times, most recently from ca0faff to 90a7453 Compare April 17, 2025 10:23
@stv0g
Copy link
Contributor Author

stv0g commented Apr 19, 2025

@JitpanuM I think, I got most of the build issues fixed. But there is a problem with the example config and the integration test thereof. Could you have a look?

@JitpanuM
Copy link
Collaborator

It seem like opendss change the working directory to /home/user/OpenDSS. That is why the integration test couldn't find the config file.

@stv0g
Copy link
Contributor Author

stv0g commented Apr 20, 2025

Ouch, that's annoying. Do you already have an idea how we can fix it?

@JitpanuM
Copy link
Collaborator

I think that modifing their source code to set the current working directory back should work.

@stv0g stv0g force-pushed the node-opendss branch 4 times, most recently from 6840754 to 111f2bb Compare April 25, 2025 07:08
@stv0g
Copy link
Contributor Author

stv0g commented Apr 25, 2025

Urgh, we get some flaky / broken integration tests now :(

I suspect that something with the timing changed.. Maybe loading the libopendssc.so library or any of the other version updates is causing this :(

We will need to split-up this PR into smaller ones unfortunately :(

@stv0g
Copy link
Contributor Author

stv0g commented Apr 25, 2025

I moved a bunch of unreleated updates to this PR #893

@stv0g
Copy link
Contributor Author

stv0g commented Apr 25, 2025

Okay, the Docker image updates (#893) have been merged into master, and I have rebased this PR onto it.

I also did some cleanup of the Git history. Please reset your local branch before pushing any more changes :) Thanks :)

@stv0g
Copy link
Contributor Author

stv0g commented Apr 28, 2025

Okay, two more fixes:

  • For some reason a member variable of an unrelated hook was not properly initialized and caused a test to fail
  • For some other reason OpenDSS is seeding the random number generator differently than VILLASnode did in the past. This broke another test.

@stv0g stv0g merged commit 085a764 into master Apr 29, 2025
2 checks passed
@stv0g stv0g deleted the node-opendss branch April 29, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants