Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve FrozenVideo and VideoDecoderCPU detectors #32

Merged
merged 19 commits into from
Jan 23, 2025

Conversation

desher
Copy link
Contributor

@desher desher commented Jan 15, 2025

Created new VideoDecoderIssueDetector that detects decoder CPU throttling in a better way than FramesDroppedIssueDetector

Improved FrozenVideoTrackDetector that uses basic video freeze metrics from getStats()

False positive results based on bad network circumstances are filtered out by additional check in VideoDecoderIssueDetector and FrozenVideoTrackDetector

Deleted FramesEncodedSentIssueDetector due to redundancy in network problem detection. QualityLimitationsIssueDetector and OutboundNetworkIssueDetector give better results.

@vlprojects-bot
Copy link
Contributor

🎉 This PR is included in version 1.14.0-debug-detectors.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vlprojects-bot
Copy link
Contributor

🎉 This PR is included in version 1.14.0-improve-base-detectors.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Collaborator

@evgmel evgmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for the improvements 🤝

@desher desher merged commit d6b7dcf into master Jan 23, 2025
4 checks passed
@desher desher deleted the improve-base-detectors branch January 23, 2025 07:24
@vlprojects-bot
Copy link
Contributor

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants