Skip to content

Sanitize fields on the test data form #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slo248 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Sanitize fields on the test data form #399

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
50d9ff6
add validation on fields of input and output files
slo248 Aug 26, 2024
31be7ef
handle flake8 errors
slo248 Aug 26, 2024
3431efc
use regex validator from django
slo248 Aug 28, 2024
6760017
add validator in the field directly
slo248 Aug 29, 2024
2f17568
fix flake8 warnings
slo248 Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions judge/views/problem_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from django.utils.html import escape, format_html
from django.utils.safestring import mark_safe
from django.utils.translation import gettext as _, gettext_lazy
from django.core.validators import RegexValidator
from django.views.generic import DetailView

from judge.highlight_code import highlight_code
Expand Down Expand Up @@ -55,11 +56,20 @@ def grader_args_cleaner(self):
return data


validate_filename = RegexValidator(
regex=r'^[a-zA-Z0-9_-]+\.[a-zA-Z0-9_-]+$',
message='%(value)s is not a valid file name with an extension.',
code='invalid_filename',
)


class ProblemDataForm(ModelForm):
io_method = ChoiceField(choices=IO_METHODS, label=gettext_lazy('IO Method'), initial='standard', required=False,
widget=Select2Widget(attrs={'style': 'width: 200px'}))
io_input_file = CharField(max_length=100, label=gettext_lazy('Input from file'), required=False)
io_output_file = CharField(max_length=100, label=gettext_lazy('Output to file'), required=False)
io_input_file = CharField(max_length=100, label=gettext_lazy(
'Input from file'), required=False, validators=[validate_filename])
io_output_file = CharField(max_length=100, label=gettext_lazy(
'Output to file'), required=False, validators=[validate_filename])
checker_type = ChoiceField(choices=CUSTOM_CHECKERS, widget=Select2Widget(attrs={'style': 'width: 200px'}))

def clean_zipfile(self):
Expand Down