feat(ranking): unify & fix pagination#450
Open
ZephyrNova47 wants to merge 1 commit intoVNOI-Admin:masterfrom
Open
feat(ranking): unify & fix pagination#450ZephyrNova47 wants to merge 1 commit intoVNOI-Admin:masterfrom
ZephyrNova47 wants to merge 1 commit intoVNOI-Admin:masterfrom
Conversation
977cd71 to
9739fa5
Compare
Contributor
|
This seem big, we will revisit it later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pagination for Contest Ranking tab
Description
Implement server-side pagination for the Ranking tab in contests. The pagination uses the canonical
?page=query parameter and renders once at the bottom of the table (no duplicate pager at the top). The default page size is 200 users per page.Type of change: New feature
What
This PR introduces pagination to the contest Ranking page and ensures it integrates cleanly with the existing auto-refresh and filtering behaviors.
Server-side pagination
?page=query parameter (e.g.,/contest/<key>/ranking/?page=2).show_virtual, filters).Template changes
#rank-partialand includecommon/pagination.htmlonce at the bottom.JavaScript changes
#ranking-table, avoiding overwriting the bottom pagination bar.Why
Fixes: N/A (feature work)
How Has This Been Tested?
Environment
DEBUG=True), MariaDB.seed-test-0001.Steps
/contest/seed-test-0001/ranking/and confirm:?page=format.?page=2,?page=5, etc. load correctly.Expected Results
?page=<n>and work correctly.Checklist
?page=format.By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.