fix: Integer Overflow or Wraparound on Multiplication result converted to larger type #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket 🎟️ #363
fix the problem, we need to ensure that the multiplication is performed using a larger integer type to avoid overflow. This can be achieved by casting one of the operands to
size_t
before performing the multiplication. This way, the multiplication will be done using thesize_t
type, which is typically larger thanunsigned int
and can hold larger values.The specific change involves modifying the multiplication expression on line 21 to cast
m_nAllocationCount
tosize_t
before multiplying it bym_unSizeOfElements
.