Fix data type for config value SetString() #365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Currently
SteamNetworkingConfigValue_t::SetString()
sets them_eDataType
tok_ESteamNetworkingConfig_Ptr
, instead ofk_ESteamNetworkingConfig_String
.This commit fixes this.
Test
I just tested this fix by editing
test_p2p.cpp
so that it uses non-global config instead.Current code fails to set the option 103 (
k_ESteamNetworkingConfig_P2P_STUN_ServerList
) with this edit:But with this fix, it reads the local config correctly: