Skip to content

Add unit test for item stack string parsing and serializing #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Minecraftschurli wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from
Open

Add unit test for item stack string parsing and serializing #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions NeoForge/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,9 @@ dependencies {

compileOnly "mezz.jei:jei-1.21-common-api:19.5.0.33"
testCompileOnly "mezz.jei:jei-1.21-common-api:19.5.0.33"
}

tasks.named('test').configure {
//Disable builtin test as we have JUnit enabled in Xplat
enabled(false)
testImplementation "org.junit.jupiter:junit-jupiter-api:5.8.1"
testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:5.8.1"
}

TaskCollection.metaClass.excludingNeoTasks = { ->
Expand Down
70 changes: 70 additions & 0 deletions NeoForge/src/test/java/vazkii/patchouli/ItemParsingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
package vazkii.patchouli;

import net.minecraft.advancements.critereon.BlockPredicate;
import net.minecraft.commands.arguments.item.ItemInput;
import net.minecraft.core.Holder;
import net.minecraft.core.HolderLookup;
import net.minecraft.core.component.DataComponentPatch;
import net.minecraft.core.component.DataComponents;
import net.minecraft.core.registries.Registries;
import net.minecraft.resources.ResourceKey;
import net.minecraft.resources.ResourceLocation;
import net.minecraft.server.MinecraftServer;
import net.minecraft.world.item.AdventureModePredicate;
import net.minecraft.world.item.Item;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.component.Unbreakable;
import net.minecraft.world.item.enchantment.Enchantment;
import net.minecraft.world.item.enchantment.Enchantments;
import net.minecraft.world.item.enchantment.ItemEnchantments;
import net.minecraft.world.level.block.Blocks;
import net.neoforged.testframework.junit.EphemeralTestServerProvider;

import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;

import vazkii.patchouli.common.util.ItemStackUtil;

import java.util.List;

import static org.junit.jupiter.api.Assertions.*;

@ExtendWith(EphemeralTestServerProvider.class)
public class ItemParsingTest {
private static final String ITEM_STRING = "minecraft:diamond_axe[minecraft:can_break={predicates:[{blocks:\"minecraft:oak_log\"}]},minecraft:unbreakable={show_in_tooltip:0b},minecraft:enchantments={levels:{\"minecraft:efficiency\":1}}]";
private static final ResourceKey<Item> ITEM_KEY = ResourceKey.create(Registries.ITEM, ResourceLocation.withDefaultNamespace("diamond_axe"));

private static Holder.Reference<Item> ITEM;
private static DataComponentPatch COMPONENTS;

@BeforeAll
public static void setup(MinecraftServer server) {
HolderLookup.Provider lookup = server.registryAccess();
HolderLookup.RegistryLookup<Item> items = lookup.lookupOrThrow(Registries.ITEM);
HolderLookup.RegistryLookup<Enchantment> enchantments = lookup.lookupOrThrow(Registries.ENCHANTMENT);
ItemEnchantments.Mutable mutable = new ItemEnchantments.Mutable(ItemEnchantments.EMPTY);
mutable.set(enchantments.getOrThrow(Enchantments.EFFICIENCY), 1);
ITEM = items.getOrThrow(ITEM_KEY);
COMPONENTS = DataComponentPatch.builder()
.set(DataComponents.CAN_BREAK, new AdventureModePredicate(List.of(BlockPredicate.Builder.block().of(Blocks.OAK_LOG).build()), true))
.set(DataComponents.UNBREAKABLE, new Unbreakable(false))
.set(DataComponents.ENCHANTMENTS, mutable.toImmutable())
.build();
}

@Test
public void testItemStackParsing(MinecraftServer server) {
List<ItemStack> result = ItemStackUtil.loadStackListFromString(ITEM_STRING, server.registryAccess());
assertEquals(1, result.size());
assertEquals(ITEM, result.getFirst().getItemHolder());
assertEquals(COMPONENTS, result.getFirst().getComponentsPatch());
assertEquals(1, result.getFirst().getCount());
}

@Test
public void testItemStackSerialization(MinecraftServer server) {
ItemInput input = new ItemInput(ITEM, COMPONENTS);
assertEquals(ITEM_STRING, input.serialize(server.registryAccess()));
}
}