fix sparce multiblock rendering in the book#798
Open
stellanera98 wants to merge 1 commit intoVazkiiMods:1.21.xfrom
Open
fix sparce multiblock rendering in the book#798stellanera98 wants to merge 1 commit intoVazkiiMods:1.21.xfrom
stellanera98 wants to merge 1 commit intoVazkiiMods:1.21.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a copy of the
Map<BlockPos, IStateMatcher>data except have it offset the BlockPos by -minX, -minY, -minZ so all the positions are translated into the space the book render is asking for.I would assume it would be possible to offset the actual data and add the offset to the offset variables but messing with the positions would probably break
IMultiblock.test()since it doesnt care for the offset variables.