A **Mostly** working port for 1.21.5 neoforge#832
Open
StoffiPoff wants to merge 41 commits intoVazkiiMods:1.21.xfrom
Open
A **Mostly** working port for 1.21.5 neoforge#832StoffiPoff wants to merge 41 commits intoVazkiiMods:1.21.xfrom
StoffiPoff wants to merge 41 commits intoVazkiiMods:1.21.xfrom
Conversation
…orge and JEI versions.
- Updates the Just Enough Items (JEI) dependency to the correct version (`21.4.0.27`) for Minecraft 1.21.5 and NeoForge, resolving the previous build failure. - Removes the deprecated `registerButton` method from the `IComponentRenderContext` interface and its implementation in `GuiBookEntry`. This addresses the deprecation warnings and aligns the code with the current API.
…precation' into refactor-patchouli-1.21.5-jei-deprecation
This commit refactors the book item model to use a custom `ItemModel` implementation. This allows for dynamic model selection based on the book's data in the `ItemStack`. - A new `BookModel` class has been created to handle the custom rendering logic. - The `NeoForgeClientInitializer` has been updated to register the new `BookModel` as a custom model type and to register the "completion" item property. - The book's item model JSON has been updated to use the new custom model loader. This change fixes the issue with the `modelRegistry` in the NeoForge client initialization and provides a more robust and flexible way to handle book item models.
…as used. The client-side resource reload listener was being incorrectly registered, causing the book data to not be loaded. This was due to using an outdated API for the project's version of NeoForge. After extensive research and multiple failed build attempts, it was discovered that the manual registration of the reload listener is no longer necessary. The code has been updated to remove the unnecessary listener, and the project now builds successfully.
…ted, no texture is loaded however.. continuing troubleshooting
…custom-item-model # Conflicts: # NeoForge/src/main/java/vazkii/patchouli/neoforge/client/NeoForgeClientInitializer.java # Xplat/src/main/java/vazkii/patchouli/common/item/ItemModBook.java
…custom-item-model # Conflicts: # NeoForge/src/main/java/vazkii/patchouli/neoforge/client/NeoForgeClientInitializer.java # Xplat/src/main/java/vazkii/patchouli/common/item/ItemModBook.java
…custom-item-model # Conflicts: # NeoForge/src/main/java/vazkii/patchouli/neoforge/client/NeoForgeClientInitializer.java
…custom-item-model # Conflicts: # NeoForge/src/main/java/vazkii/patchouli/neoforge/client/NeoForgeClientInitializer.java # Xplat/src/main/java/vazkii/patchouli/common/item/ItemModBook.java
Corrects an issue where ingredients for shaped crafting recipes were not being displayed in the crafting page. This was caused by an incorrect `instanceof` check that prevented the ingredient processing logic from running. The check has been updated to use the correct `ShapedCraftingRecipeDisplay` type, and the method for retrieving ingredients has been corrected to `ingredients()`.
…cond result item is shown beneath the original
Recipes render fine in the gui, missing some parts for different crafting stations though. Trying to implement pick with middle mouse button for the rendered visual but it's tricky to get right, not fully implemented yet. Almost all parts of the original 1.21.1 mod works now for neoforge 1.21.5 but I am still struggling with implementing the book model generation.
Fix crafting ingredient rendering
Recipes render fine in the gui, missing some parts for different crafting stations though. Trying to implement pick with middle mouse button for the rendered visual but it's tricky to get right, not fully implemented yet. Almost all parts of the original 1.21.1 mod works now for neoforge 1.21.5 but I am still struggling with implementing the book model generation.
…ngredient-rendering
Fix crafting ingredient rendering
1.21.5 model pipeline
…om/StoffiPoff/Patchouli into patchouli-1.21.5-neoforge-refactor
…emented pickblock for the ghost blocks in the render.
…om/StoffiPoff/Patchouli into patchouli-1.21.5-neoforge-refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs further review and work and testing but mostly works on 1.21.5 now.