Skip to content

Fix dashboard dynamic page prop types#31

Merged
VectoDE merged 2 commits intomainfrom
codex/fix-typescript-type-errors-in-pages
Nov 1, 2025
Merged

Fix dashboard dynamic page prop types#31
VectoDE merged 2 commits intomainfrom
codex/fix-typescript-type-errors-in-pages

Conversation

@VectoDE
Copy link
Copy Markdown
Owner

@VectoDE VectoDE commented Nov 1, 2025

Summary

  • wrap each dashboard edit route in a server component that awaits the promised route params before rendering the client UI
  • move the edit page implementations into dedicated client components that validate the id, fetch data, and keep existing CRUD flows intact
  • update the project view page to await the promised params and normalize certificate date defaults to strings

Testing

  • pnpm typecheck

https://chatgpt.com/codex/tasks/task_e_69064eb9d530832caca2c65effcb1016

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
portfolio Ready Ready Preview Comment Nov 1, 2025 6:31pm

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +260 to +263
<SelectItem value="beginner">Beginner</SelectItem>
<SelectItem value="intermediate">Intermediate</SelectItem>
<SelectItem value="advanced">Advanced</SelectItem>
<SelectItem value="expert">Expert</SelectItem>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Align skill level option values with stored strings

Select uses defaultValue={skill.level} from existing records, but the rendered options now have lowercase value attributes (e.g. "beginner"). When an existing skill with level "Beginner" is edited and the user submits without changing the select, no option matches the default so the field submits null. The update handler then tries to write level: null to Prisma's non-nullable Skill.level column, causing the save request to fail. The option values should match the stored casing or the code should normalize both sides before submission.

Useful? React with 👍 / 👎.

@VectoDE VectoDE merged commit e6c99f9 into main Nov 1, 2025
6 checks passed
@VectoDE VectoDE deleted the codex/fix-typescript-type-errors-in-pages branch November 1, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant