[Rust] Restructure type APIs into types module
#7779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emesare
force-pushed
the
test_rust_types_mod
branch
from
cf8379e to
ae3e75b
Compare
This helps with documentation, giving a single module for those working with types to find related APIs Also split out enumeration and structure APIs into their own file, since they have their own backing data separate from `Type`.
emesare
force-pushed
the
test_rust_types_mod
branch
from
ae3e75b to
d1da7e1
Compare
Member
Author
|
One unfortunate thing is we keep QualifiedName in the types module, I think we should move it out and re-export it within types module with a deprecation notice. |
This is used in more places than types, so its best we keep it separate.
emesare
force-pushed
the
test_rust_types_mod
branch
from
ba32791 to
aec0d26
Compare
- Added some unit tests - Improved documentation - Made `QualifiedName::new` and `QualifiedName::new_with_separator` generic over `Into<String>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with documentation, giving a single module for those working with types to find related APIs
Also split out enumeration and structure APIs into their own file, since they have their own backing data separate from
Type.This does not actually break any plugins since these modules that were moved and not re-exported are not used as of yet.
The APIs which are being used have re-exports that allow existing code to correctly import.