Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧪 [testing improvement] Add unit tests for sanitize_filename #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
🧪 [testing improvement] Add unit tests for sanitize_filename #230
Changes from all commits
98c5cb6File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 14 in Cachyos/Scripts/WIP/emu/test_sanitize_filename.py
Cachyos/Scripts/WIP/emu/test_sanitize_filename.py#L14
Check notice on line 18 in Cachyos/Scripts/WIP/emu/test_sanitize_filename.py
Cachyos/Scripts/WIP/emu/test_sanitize_filename.py#L18
Check notice on line 24 in Cachyos/Scripts/WIP/emu/test_sanitize_filename.py
Cachyos/Scripts/WIP/emu/test_sanitize_filename.py#L24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Incorrect expected value - the output should have double spaces where special characters were removed.
The characters
!,@,#,$,%,^,&,*,(,),+,=are all removed, leaving two consecutive spaces between "test" and "" and between "" and "file.cia".Current expected:
"test _ file.cia"Correct expected:
"test _ file.cia"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests can be consolidated into a single, data-driven method using
subTestfor improved maintainability and readability. This refactoring also allows for easily adding more test cases.I've included new test cases for Unicode and emoji characters. The current
sanitize_filenameimplementation appears to have a bug with characters outside the Latin-1 range (e.g., emoji) because it only considersrange(256). The new test case for emoji will fail, highlighting this gap in functionality and test coverage.Check notice on line 47 in Cachyos/Scripts/WIP/emu/test_sanitize_filename.py
Cachyos/Scripts/WIP/emu/test_sanitize_filename.py#L47
Uh oh!
There was an error while loading. Please reload this page.