Skip to content

fix: address review follow-ups in consolidated merge

1505f48
Select commit
Loading
Failed to load commit list.
Merged

Consolidate open PR changes into a single main-ready branch #245

fix: address review follow-ups in consolidated merge
1505f48
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Mar 18, 2026 in 0s

16 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 16
           

Complexity increasing per file
==============================
- Cachyos/Scripts/WIP/gphotos/Splitter.py  3
- Cachyos/Scripts/WIP/emu/cia_3ds_decryptor.py  11
- Cachyos/Scripts/WIP/gphotos/test_splitter.py  1
- Cachyos/Scripts/WIP/emu/test_decryptor_parser.py  4
- Cachyos/Scripts/WIP/emu/test_sanitize_filename.py  5
- Cachyos/Scripts/WIP/emu/test_decryptor_contentid.py  5
         

Clones added
============
- Cachyos/Scripts/WIP/emu/test_decryptor_parser.py  2
- Cachyos/Scripts/WIP/emu/test_sanitize_filename.py  2
- Cachyos/Scripts/WIP/emu/test_decryptor_contentid.py  1
         

See the complete overview on Codacy

Annotations

Check warning on line 301 in Cachyos/Scripts/WIP/emu/cia_3ds_decryptor.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/cia_3ds_decryptor.py#L301

Method _handle_twl_cia has 70 lines of code (limit is 50)

Check warning on line 301 in Cachyos/Scripts/WIP/emu/cia_3ds_decryptor.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/cia_3ds_decryptor.py#L301

Method _handle_twl_cia has 9 parameters (limit is 8)

Check warning on line 373 in Cachyos/Scripts/WIP/emu/cia_3ds_decryptor.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/cia_3ds_decryptor.py#L373

Method _handle_standard_cia has 10 parameters (limit is 8)

Check warning on line 373 in Cachyos/Scripts/WIP/emu/cia_3ds_decryptor.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/cia_3ds_decryptor.py#L373

Method _handle_standard_cia has 74 lines of code (limit is 50)

Check warning on line 621 in Cachyos/Scripts/WIP/emu/cia_3ds_decryptor.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/cia_3ds_decryptor.py#L621

Method run_decryption has a cyclomatic complexity of 9 (limit is 8)

Check warning on line 15 in Cachyos/Scripts/WIP/emu/test_decryptor_contentid.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/test_decryptor_contentid.py#L15

Item "None" of "Loader | None" has no attribute "exec_module". (union-attr)

Check notice on line 26 in Cachyos/Scripts/WIP/emu/test_decryptor_contentid.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/test_decryptor_contentid.py#L26

Method name "test_extract_content_ids_no_file" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern

Check notice on line 29 in Cachyos/Scripts/WIP/emu/test_decryptor_contentid.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/test_decryptor_contentid.py#L29

Method name "test_extract_content_ids_valid_file" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern

Check warning on line 14 in Cachyos/Scripts/WIP/emu/test_decryptor_parser.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/test_decryptor_parser.py#L14

Item "None" of "Loader | None" has no attribute "exec_module". (union-attr)

Check notice on line 28 in Cachyos/Scripts/WIP/emu/test_decryptor_parser.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/test_decryptor_parser.py#L28

Method name "test_parse_ctrtool_output_partial" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern

Check notice on line 41 in Cachyos/Scripts/WIP/emu/test_decryptor_parser.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/test_decryptor_parser.py#L41

Method name "test_parse_twl_ctrtool_output_full" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern

Check notice on line 52 in Cachyos/Scripts/WIP/emu/test_decryptor_parser.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/test_decryptor_parser.py#L52

expected 2 blank lines after class or function definition, found 1 (E305)

Check warning on line 14 in Cachyos/Scripts/WIP/emu/test_sanitize_filename.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/test_sanitize_filename.py#L14

Item "None" of "Loader | None" has no attribute "exec_module". (union-attr)

Check notice on line 18 in Cachyos/Scripts/WIP/emu/test_sanitize_filename.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/test_sanitize_filename.py#L18

Method name "test_preservation_of_valid_characters" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern

Check notice on line 24 in Cachyos/Scripts/WIP/emu/test_sanitize_filename.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/emu/test_sanitize_filename.py#L24

Method name "test_removal_of_invalid_characters" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern

Check notice on line 86 in Cachyos/Scripts/WIP/gphotos/test_splitter.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Cachyos/Scripts/WIP/gphotos/test_splitter.py#L86

Method name "test_get_latest_group_info_missing_directory" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern