Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement nondeterministic finite transducers (NFTs) #465

Merged
merged 148 commits into from
Dec 2, 2024
Merged

Implement nondeterministic finite transducers (NFTs) #465

merged 148 commits into from
Dec 2, 2024

Conversation

Adda0
Copy link
Collaborator

@Adda0 Adda0 commented Nov 18, 2024

This PR meres transducers from the feature branch into the main devel branch of Mata. All subsequent updates to transducers will be performed on the devel branch.

@Adda0 Adda0 force-pushed the transducers branch 4 times, most recently from 93aafc0 to 62f8c2f Compare November 22, 2024 14:32
@Adda0 Adda0 marked this pull request as ready for review November 22, 2024 14:42
@Adda0 Adda0 force-pushed the transducers branch 2 times, most recently from 8659dfa to 4a05cc0 Compare November 25, 2024 10:26
@Adda0 Adda0 requested review from jurajsic and koniksedy December 2, 2024 09:01
jurajsic
jurajsic approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@jurajsic jurajsic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just merge it, we will find bugs when we start to use it

koniksedy
koniksedy approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@koniksedy koniksedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Juraj. Just merge it.

koniksedy and others added 19 commits December 2, 2024 12:21
@koniksedy @Adda0
lvlfa as a duplicate of nfa
9531261
@koniksedy @Adda0
lvlfa builder done
cbc6860
@koniksedy @Adda0
make_one_level nontested
f85e803
@Adda0
Improve levels description
6d31558
@Adda0
Create identity NFT
54bd0fa
@Adda0
Add moves wherever possible
4b1cf1c
@Adda0
Create identity with single replace
b7c87d8
@Adda0
Rename 'lvlfa' to 'nft'
00fc80d
@Adda0
Create NFT from NFA
85b9cea
@Adda0
Check number of levels in equivalence checking
2cf77fb
@Adda0
Implement end marker DFT for reluctant replacement
25092ba
@Adda0
Move NFT string solving function into their own namespace
5c2e878
@Adda0
Create generic end marker DFT
148b97b
@Adda0
Generalize end_marker_dft() for general marker DFTconstruction
2679306
@koniksedy @Adda0
nft::are_quivalent implemented using the method get_one_level_aut
b9f0b50
@Adda0
Rename functions
964118f
@koniksedy @Adda0
nft::algorithms::is_included_antichains implemented using the method …
a94b46e 
…get_one_level_aut
@Adda0
Construct begin marker DFT
d425bd9
@Adda0
Apply resize() levels instead of push_back() only when needed
99cd541
Adda0 and others added 21 commits December 2, 2024 12:21
@Adda0
Merge pull request #397 from VeriFIT/insert_levels-optimize_size
b9e780b 
Insert levels optimize number of inner states
@Adda0
Fix formatting
16f8745
@Adda0
tmpfix: Hide unused-parameter warning
e8cc058
@koniksedy @Adda0
Merge pull request #398 from VeriFIT/refactor_string_solving_operations
880d99b 
Refactor string solving operations
@Adda0
Fix reluctant leftmost nft creation
5b53e48
@koniksedy @Adda0
Merge pull request #403 from VeriFIT/apply
f40066e 
Apply NFA to NFT
@koniksedy @Adda0
Merge pull request #405 from VeriFIT/fix_transducer_operations
6a9c66f 
Fix transducer operations
@Adda0
Fix creating identity
a57573e
@Adda0
Remove unnecessary whitespace
34c1874
@Adda0
Improve print_to_dot
ee4638c
@Adda0
refactor: Use prefix increment when possible
67c220c
@Adda0
refactor(nft): Improve builder code
cb82b0e
@Adda0
fix: Unify naming of source and target states
4da828b
@Adda0
feat(delta): Allow accessing state_posts_ in inherited Deltas
b67a3e4
@Adda0
fix(nfa): Use SparseSets in Nfa constructors to allow moves
ad3b3b7
@Adda0
feat(nft): Set number of levels when building common NFTs
7ba5fd0
@Adda0
refactor(nft): Fix parameter names and types
f0189b6
@Adda0
style: Format code
79b946e
@Adda0
feat(nft): Use LevelsNum in .mata format
5233f43
@Adda0
feat(nft): Create NFTs with a specified number of levels easily
1ef521d
@Adda0
fix(levels): Fix implicit conversion for Levels class
0397596
@Adda0 Adda0 merged commit c277508 into devel Dec 2, 2024
15 checks passed
@Adda0 Adda0 deleted the transducers branch December 2, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurajsic jurajsic jurajsic approved these changes

@koniksedy koniksedy koniksedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Adda0 @jurajsic @koniksedy