Skip to content

No multi-contract integration test verifying state isolation between two deployed instances #169

Closed

Description

@N-thnI

Problem

plan.md's Testing section explicitly asks for: "Multi-contract integration — write an integration test that deploys two contract instances and verifies that guardian state does not leak between them." No existing test deploys two VeroContract instances in the same test and asserts their storage is isolated.

Why it matters

All contract state lives in instance storage (per README.md's Storage Design section), which is scoped per-deployment — but that scoping is a Soroban platform guarantee this project has never actually exercised with a test, and instance-storage bugs (e.g. a future refactor accidentally using shared/persistent storage) wouldn't be caught by any existing single-instance test.

Suggested fix

Add a test that deploys two separate VeroContract instances (two contract_ids from env.register_contract), initializes each independently with different admins/tokens, adds a guardian to only one, and asserts is_guardian/get_reputation/get_task on the other instance shows no leakage.

Acceptance criteria

  • Test deploys two instances and asserts complete state isolation across guardians, tasks, and reputation

Activity

  1. IfyJustin91 commented on Aug 24, 2026

    @IfyJustin91
    Contributor

    hi, i would like to work on this issue

  2. grantfox-oss commented on Aug 24, 2026

    @grantfox-oss

    🦊 GrantFox — @IfyJustin91 has been assigned to this issue as part of the Third Campaign campaign!

    Next steps:

    1. Open a Pull Request referencing this issue (e.g., Closes #169)
    2. Your PR will be reviewed by the Vero-protocol maintainers

    Good luck! Track your progress on GrantFox.

  3. grantfox-oss commented on Aug 30, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @IfyJustin91's PR #308 was approved and merged by @N-thnI.

    🏆 @IfyJustin91: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (993 total points). Track your full progress on GrantFox.

    👏 Great work, @IfyJustin91! Keep contributing to Vero-protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26good first issueGood for newcomerstestingTest coverage improvements

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions