Skip to content
This repository was archived by the owner on Feb 21, 2024. It is now read-only.

fix: runner tests #308

Closed
wants to merge 2 commits into from
Closed

fix: runner tests #308

wants to merge 2 commits into from

Conversation

renancaraujo
Copy link
Contributor

Description

fix: runner tests VeryGoodOpenSource/very_good_cli#766

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@renancaraujo renancaraujo requested a review from a team as a code owner November 10, 2023 15:45
Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried reproducing VeryGoodOpenSource/very_good_cli#766 but did not get any warning (as detailed in the issue) when running the development flavour on iPhone 15 Pro Max (simulator).

Logs (main)

flutter run --flavor development --target lib/main_development.dart
Launching lib/main_development.dart on iPhone 15 Pro Max in debug mode...
Running Xcode build...
└─Compiling, linking and signing... 8.5s
Xcode build done. 25.0s
[VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(37)] Using the Impeller rendering backend.
Syncing files to device iPhone 15 Pro Max... 270ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h List all available interactive commands.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

A Dart VM Service on iPhone 15 Pro Max is available at: http://127.0.0.1:59061/6z_KrFBRxSQ=/
The Flutter DevTools debugger and profiler on iPhone 15 Pro Max is available at:
http://127.0.0.1:9101?uri=http://127.0.0.1:59061/6z_KrFBRxSQ=/

However, I tried running the renan/runner-tests branch, following the same steps, and it failed.

Logs (renan/runner-tests)

flutter run --flavor development --target lib/main_development.dart

Launching lib/main_development.dart on iPhone 15 Pro Max in debug mode...
Running Xcode build...
└─Compiling, linking and signing... 1,045ms
Xcode build done. 4.1s
Failed to build iOS app
Swift Compiler Error (Xcode): No such module 'XCTest'
/Users/ale/Developer/workspace/oss/very_good_core/src/my_app/ios/RunnerTests/RunnerTests.swift:2:7

Could not build the application for the simulator.
Error launching application on iPhone 15 Pro Max.

Am I missing something?

@alestiago
Copy link
Contributor

I'm still getting an error. I made a flutter clean, then a flutter run, made sure I was in renan/runner-tests and up to date with the latest commit and finally run using flutter run --flavor development --target lib/main_development.dart on iPhone 15 Pro Max.

Logs (renan/runner-tests)
Launching lib/main_development.dart on iPhone 15 Pro Max
in debug mode...
Running Xcode build...                                                  
 └─Compiling, linking and signing...                         3.5s
Xcode build done.                                           16.8s
Failed to build iOS app
Swift Compiler Error (Xcode): No such module 'XCTest'
/Users/alestiago/Developer/workspace/oss/very_good_core/src/my_app/ios/RunnerTests/RunnerTe
sts.swift:2:7


Could not build the application for the simulator.
Error launching application on iPhone 15 Pro Max.

@alestiago alestiago deleted the renan/runner-tests branch November 16, 2023 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants