-
Notifications
You must be signed in to change notification settings - Fork 44
implement tenants endpoint for victorialogs #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
vadimalekseev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Someone please verify the logic of tenants parsing
|
@dmitryk-dk , could you rebase this pull request on top of the #709 ? |
|
OK dk is 1 step ahead of me so I'll leave the rebase work to him. Let me know if anything I can help with. |
f94cd16 to
68a2147
Compare
Hi @valyala , @jiekun ! I have rebased the code to this branch. Write data Select tenants Checked the same for the single |
implement tenants endpoint for victorialogs
859e99a to
c031580
Compare
…nd `non-existing-non-empty-tag-re` This is a follow-up for 918ccca . See also #417 (comment)
implement tenants endpoint for victorialogs
Describe Your Changes
Implemented endpoint like VictoriaMetrics has /select/admin/tenants. This endpoint returns tenants from the storage as slice of strings like []{"0:0", "1:0"}.
This endpoint can help to build UI with requests per tenant.
Checked both solutions, single version and cluster. Fixed all comments from this VictoriaMetrics/VictoriaMetrics#7484
Checklist
The following checks are mandatory: