tokenizeString performance improved by 57% #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
func25
reviewed
Oct 29, 2025
Comment on lines
199
to
211
| // Search for the end of the token. | ||
| end := len(s) | ||
| for i < len(s) { | ||
| c := *(*byte)(unsafe.Add(ptr, uintptr(i))) | ||
| found := lookupTables[curUnicodeFlag][c] | ||
| if found != 0 { | ||
| i++ | ||
| continue | ||
| } | ||
| end = i | ||
| i++ | ||
| break | ||
| } |
There was a problem hiding this comment.
If the token starts with ASCII and later has Unicode bytes, it may break early. Should probably recalculate unicodeFlag per byte here.
There was a problem hiding this comment.
fixed.
36.5% faster than old version.
|
@func25 could you review this again ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Checklist
The following checks are mandatory:
@valyala
I'm sorry, I don't participate much in open source projects. It seems I'm not following the proper procedures and etiquette enough. I'd appreciate some guidance if I find myself doing things inappropriately.
Could you please take a moment to review my PR? My idol